Improve error messages related to incompatible Futures #102
Conversation
Avaq
force-pushed
the
avaq/sanctuary-type-identifiers-2
branch
from
2d2fcd8
to
7763ad7
Compare
Codecov Report
@@ Coverage Diff @@
## 6.0 #102 +/- ##
===================================
Coverage 100% 100%
===================================
Files 36 36
Lines 969 980 +11
===================================
+ Hits 969 980 +11
Continue to review full report at Codecov.
|
| + '\n See: https://github.com/fluture-js/Fluture#casting-futures' | ||
| ); | ||
|
|
||
| export const invalidFuture = (it, at, m, s = '') => { |
There was a problem hiding this comment.
I know. This function has a pretty ugly signature: (String, String | Number, Any, String | Nil) -> Void. It's like that because it supports several different combinations of use-cases. It's completely unoptimizable, but I don't care, because the only time this function is called is right before the process crashes.
|
|
||
| export const namespace = 'fluture'; | ||
| export const name = 'Future'; | ||
| export const version = 2; |
There was a problem hiding this comment.
Why 2? Also, what is your plan for updating this value when appropriate?
There was a problem hiding this comment.
Version 2 because all Futures between 1.0.0 and 5.0.0 are conceptually version 1 (even though never explicitly specified). The version number changes when a change to the class surface is made. For example, all futures before 6.0.0 had an _f-method which Fluture expects and makes use of. Since 6.0.0 this has been renamed to _fork. Fluture 6.0.0 is therefore (and for more subtle reasons to do with the way Actions are implemented) incapable of consuming older Fluture Futures.
Avaq
force-pushed
the
avaq/sanctuary-type-identifiers-2
branch
from
7763ad7
to
68c447d
Compare
Avaq
force-pushed
the
avaq/sanctuary-type-identifiers-2
branch
from
68c447d
to
01bb5dd
Compare
Breaking changes - #80 The ES5 import has been moved from `fluture/es5` to `fluture`. - #80 The `Future#hook` *method* (but not the function) has been removed. - #80 Old environments are asked to bring their own polyfills for `Object.create`, `Object.assign` and `Array.isArray`. - #96 The arguments to the `ap`-method have been flipped back. - #97 `and` and `or` no longer run the two Futures in parallel. - #98 `fromPromise` has been renamed to `encaseP`. New features - #80 Added an ES6 module for use with tools like [Rollup](https://rollupjs.org/). - #80 All transformations, including recursive `chain`, are now stack safe! - #80 Added `isNever`. - #80 Added aliases `attempt = try`, `go = do`, `lastly = finally`. - #98 Added `tryP`, the nullary version of `encaseP`. Bug fixes and improvements - Added fast failure to `encase` and `encaseP`. - #98 Errors thrown while transforming Futures produced by `tryP` or `encaseP` no longer get caught (and silenced) by the Promise. - #80 User-supplied functions no longer have strict arity requirements. - #80 `Future.hook` no longer cancels the acquire Future after it has settled. - #80 `Future.hook` now always cancels running Futures appropriately. - #102 Supplying incompatible or outdated instances of Fluture now throws more sensible error messages.
Builds on
sanctuary-type-identifiers@2.0.0.Closes #85