Change and and or to be sequential
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/sequential-and-or
branch
3 times, most recently
from
e695cc4
to
9e627b7
Compare
Avaq
force-pushed
the
avaq/sequential-and-or
branch
from
9e627b7
to
e23c9e3
Compare
Codecov Report
@@ Coverage Diff @@
## 6.0 #97 +/- ##
===================================
Coverage 100% 100%
===================================
Files 36 36
Lines 972 966 -6
===================================
- Hits 972 966 -6
Continue to review full report at Codecov.
|
|
|
||
| Returns a new Future which either rejects with the first rejection reason, or | ||
| resolves with the last resolution value once and if both Futures resolve. This | ||
| behaves analogues to how JavaScript's and operator does. |
There was a problem hiding this comment.
This should either read:
- This behaves analogously to…; or
- This behaviour is analogous to….
There was a problem hiding this comment.
Oh. Thanks. That has been in there since 0.x, I think. 😳
Avaq
added a commit
that referenced
this pull request
May 13, 2017
Breaking changes - #80 The ES5 import has been moved from `fluture/es5` to `fluture`. - #80 The `Future#hook` *method* (but not the function) has been removed. - #80 Old environments are asked to bring their own polyfills for `Object.create`, `Object.assign` and `Array.isArray`. - #96 The arguments to the `ap`-method have been flipped back. - #97 `and` and `or` no longer run the two Futures in parallel. - #98 `fromPromise` has been renamed to `encaseP`. New features - #80 Added an ES6 module for use with tools like [Rollup](https://rollupjs.org/). - #80 All transformations, including recursive `chain`, are now stack safe! - #80 Added `isNever`. - #80 Added aliases `attempt = try`, `go = do`, `lastly = finally`. - #98 Added `tryP`, the nullary version of `encaseP`. Bug fixes and improvements - Added fast failure to `encase` and `encaseP`. - #98 Errors thrown while transforming Futures produced by `tryP` or `encaseP` no longer get caught (and silenced) by the Promise. - #80 User-supplied functions no longer have strict arity requirements. - #80 `Future.hook` no longer cancels the acquire Future after it has settled. - #80 `Future.hook` now always cancels running Futures appropriately. - #102 Supplying incompatible or outdated instances of Fluture now throws more sensible error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95