Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README with more precise comparisons with Promises. #348

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

galileopy
Copy link

Changing the description of "equivalent with Promises" to "approximation with Promises",
Fixing an example in the bimap section to have the example that would actually work as bimap
Adding rejection branch in fold example with Promises, since then is almost like a foldChain overloaded monster.

Copy link
Member

@Avaq Avaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small nitpick below, all changes look good to me. If you'll make that change and squash your commits into one, we can merge it. After merging, I'll merge the 11.x branch back into master, updating the beta docs as well.

README.md Outdated
@@ -855,7 +855,7 @@ Future.of(1)
//> 2
```

For comparison, the equivalent with Promises is:
For comparison, the approximation with Promises is:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using "the approximation", let's use "an approximation" across the docs, as there are most likely more than one approximation.

@galileopy galileopy force-pushed the readme-promise-approximation branch from 3523177 to 178b629 Compare June 18, 2019 13:38
@codecov

This comment has been minimized.

1 similar comment
@codecov

This comment has been minimized.

@Avaq
Copy link
Member

Avaq commented Jun 20, 2019

Thanks! :)

@Avaq Avaq merged commit 8284c87 into fluture-js:11.x Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants