Improve TypeScript type inference #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Revert #230 and reintroduce the usage of the 'never' type - Relax the signature of chain and chainRej to allow TypeScript to derive types when merging a Future of a never with a Future of a real type. Closes #337 and closes #370. - Move generic types closer to where they are used in the function signature. Closes #372 and closes #373 through supersession. Co-authored-by: Edgar Rodriguez <edgarj.rodriguezg@gmail.com>
|
@davidchambers I asked you for a review because I know you've been working on typings for Sanctuary, and you would've likely encountered the same issues with |
This comment has been minimized.
This comment has been minimized.
|
Note that the changes I made to |
This comment has been minimized.
This comment has been minimized.
davidchambers
approved these changes
Sep 26, 2019
|
Together with some regular TypeScript users I have tried to find a solution which does not compromise on the strictness of |
Avaq
added a commit
that referenced
this pull request
Oct 8, 2019
Breaking changes - #345 #383 The modular version of Fluture has been moved from `index.mjs` to 'index.js', and has been made compatible with Node 12. In Node 9, 10, and 11, the modular version must now be loaded with the help of the 'esm' loader. - #378 The 'fold' function has been renamed to 'coalesce'. - #377 The 'Future' constructor is no longer overloaded with a version that allows the computation to return 'void'. New features - #355 The npm package now ships with some of Fluture's testing internals. The API is experimental and subject to breaking changes. Improvements - #374 TypeScript types have been improved to get better inference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussions had in #337 and #370, I think our problems cannot be solved without compromising the strictness of the
chainandchainRejfunctions. This PR makes the following changes to get type inference to work well:derive types when merging a Future of a never with a Future of a
real type. Closes Stop using user-assignable type generics in the types of functions that don't do anything with them #337 and closes types of fold #370.
signature. Closes Move TypeScript generics as deeply into function signatures as possible #372 and closes Move the declaration of generics deeper into type signatures #373 through supersession.
/cc @edgarjrg, @tetsuo