-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use type variables in TypeScript typings instead of never #230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 1187 1187
=====================================
Hits 1187 1187 Continue to review full report at Codecov.
|
I believe this approach is the better one in all instances where |
Would you like to make the proposed adjustment to all the other |
fbb0498
to
aa3a957
Compare
The final build requires Should we consider adding a |
This looks great! Thank you. I remain of the opinion that package locks are only relevant in "root" level packages, eg applications. It's a feature to accommodate safer deployments. When installing a package as a dependency, I believe its package lock is ignored. Instead, I use greenkeeper to react to broken dependencies. |
e00f2ef
to
613291d
Compare
Breaking changes - #224 Exceptions are now caught and rethrown in `fork`. - #230 Many of the TypeScript type definitions that used `never` now use a generic instead. - #238 When unsubscribing from a Future created by `hook`, the cancellation signal is no longer sent to the disposal Future. - #266 Exported TypeScript interfaces have been renamed to avoid naming conflicts with exported values. New features - #250 Included interoperability with Sanctuary Show - #261 Added a new function, `forkCatch`, which allows for exception recovery.
- Revert #230 and reintroduce the usage of the 'never' type - Relax the signature of chain and chainRej to allow TypeScript to derive types when merging a Future of a never with a Future of a real type. Closes #337 and closes #370. - Move generic types closer to where they are used in the function signature. Closes #372 and closes #373 through supersession. Co-authored-by: Edgar Rodriguez <edgarj.rodriguezg@gmail.com>
TSC throws a compilation error in here, since
of
always assumes that it doesn't throw a rejection.Adding a new type variable instead using never should fix the issue, but it might break other things where the error type is not specified explicitly.
@Avaq I added it to
of
andafter
. Anything else that needs to be fixed?