Skip to content

Commit

Permalink
job-list: make replay KVS errors non-fatal
Browse files Browse the repository at this point in the history
Problem: the job manager now treats jobs that cannot be loaded
from the KVS as a non-fatal error, but job-list treats them
as fatal still.

Relax error handling so that replay continues if a job cannot be
loaded.  Most likely the job will have already been logged by
the job manager so introduce no new logging here.
  • Loading branch information
garlick committed May 4, 2023
1 parent 448fb08 commit 6db9928
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/modules/job-list/job_state.c
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ static int depthfirst_map_one (struct job_state_ctx *jsctx,
flux_future_t *f3 = NULL;
const char *eventlog, *jobspec, *R;
char path[64];
int rc = -1;
int rc = 0; // non-fatal error

if (strlen (key) <= dirskip) {
errno = EINVAL;
Expand Down Expand Up @@ -736,7 +736,7 @@ static int depthfirst_map_one (struct job_state_ctx *jsctx,

rc = 1;
done:
if (rc < 0)
if (rc == 0)
job_destroy (job);
flux_future_destroy (f1);
flux_future_destroy (f2);
Expand Down

0 comments on commit 6db9928

Please sign in to comment.