Merge pull request #5959 from chu11/issue5956_demote_assertion

libsubprocess: demote assert to warning
flux-framework · May 16, 2024 · a3cfb3b · a3cfb3b
2 parents be2fcf4 + 58e9ade
commit a3cfb3b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/common/libsubprocess/subprocess.c b/src/common/libsubprocess/subprocess.c
@@ -246,7 +246,11 @@ void subprocess_standard_output (flux_subprocess_t *p, const char *stream)
 
 void subprocess_check_completed (flux_subprocess_t *p)
 {
-    assert (p->state == FLUX_SUBPROCESS_EXITED);
+    if (p->state != FLUX_SUBPROCESS_EXITED) {
+        log_err ("subprocess_check_completed: unexpected state %s",
+                 flux_subprocess_state_string (p->state));
+        return;
+    }
 
     /* we're also waiting for the "complete" to come from the remote end */
     if (!p->local && !p->remote_completed)