Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/security: Fix test corner case #1029

Merged
merged 1 commit into from Apr 5, 2017
Merged

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Apr 5, 2017

Check for EACCES depends on system setup and errno may be something
else such as EROFS or EPERM. Genericize test to simply check for
failure.

Check for EACCES depends on system setup and errno may be something
else such as EROFS or EPERM.  Genericize test to simply check for
failure.
@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #1029 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   77.91%   77.87%   -0.04%     
==========================================
  Files         150      150              
  Lines       25494    25494              
==========================================
- Hits        19863    19853      -10     
- Misses       5631     5641      +10
Impacted Files Coverage Δ
src/common/libflux/info.c 76.11% <0%> (-2.99%) ⬇️
src/common/libflux/request.c 89.04% <0%> (-1.37%) ⬇️
src/common/libflux/rpc.c 91.17% <0%> (-1.11%) ⬇️
src/broker/module.c 82.15% <0%> (-0.29%) ⬇️
src/common/libflux/dispatch.c 83.15% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 85.52% <0%> (-0.26%) ⬇️
src/common/libflux/message.c 80.77% <0%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac055a9...7d891ae. Read the comment docs.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7d891ae on chu11:issue1028 into ** on flux-framework:master**.

@garlick
Copy link
Member

garlick commented Apr 5, 2017

Thanks @chu11, looks good.

@garlick garlick merged commit a9f4cd5 into flux-framework:master Apr 5, 2017
@grondo grondo mentioned this pull request Aug 23, 2017
@chu11 chu11 deleted the issue1028 branch June 5, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants