build: switch to AX_VALGRIND_H for valgrind.h detection #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AX_VALGRIND_H macro for detection of valgrind.h existence in one of several circumstances: - valgrind.pc pkg-config file found and either valgrind.h or valgrind/valgrind.h found - no valgrind.pc pkg-config found and either valgrind.h or valgrind/valgrind.h found if any case is found then HAVE_VALGRIND is set along with HAVE_VALGRIND_VALGRIND_H and/or HAVE_VALGRIND_H depending on which header file is found.
Switch to AX_VALGRIND_H macro to find valgrind.h for valgrind wrap of dlclose symbol in the flux-broker. Add resulting $(VALGRIND_CFLAGS) to broker build, and fix up use of HAVE_VALGRIND, HAVE_VALGRIND_H, and HAVE_VALGRIND_VALGRIND_H.
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
- Coverage 78.77% 78.75% -0.03%
==========================================
Files 164 164
Lines 30673 30673
==========================================
- Hits 24164 24157 -7
- Misses 6509 6516 +7
|
|
Sounds good - thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in ax_valgrind.m4 recently merged to flux-sched for consistency (and to handle case where valgrind.h wouldn't be properly detected if only available via PKG_CHECK_MODULES)