Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content-{sqlite,files,s3}: register backing store after registering services #4456

Closed
chu11 opened this issue Aug 1, 2022 · 0 comments · Fixed by #4458
Closed

content-{sqlite,files,s3}: register backing store after registering services #4456

chu11 opened this issue Aug 1, 2022 · 0 comments · Fixed by #4458
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Aug 1, 2022 •
edited
Loading

While working on #4267, realized that ENOSYS errors encountered are due to the fact that the content-{sqlite,files,s3} modules all register themselves as backing stores BEFORE registering their services. This makes it so that cache_flush() and similar things in the content-cache cannot work during the registration process.

The calls should be reversed.

The issues targeted in PR #4380 were specifically different, but highly related to this issue.
@chu11 chu11 self-assigned this Aug 1, 2022
chu11 added a commit to chu11/flux-core that referenced this issue Aug 1, 2022
@chu11
content-sqlite,files,s3: perform setup correctly
ef6db9c 
Problem: In the content-sqlite, content-files, and content-s3 modules,
the backing module is registered before setup of the service is
complete.  This can cause problems if the broker's content-cache
wants to make calls into the module during registration time.

Solution: Ensure that all setup is complete before registering the
backing module.

Update regression test which would fail with this change.

Fixes flux-framework#4456
chu11 added a commit to chu11/flux-core that referenced this issue Aug 1, 2022
@chu11
content-sqlite,files,s3: register module later
a16a335 
Problem: In the content-sqlite, content-files, and content-s3 modules,
the backing module is registered before setup of the service is
complete.  This can cause problems if the broker's content-cache
wants to make calls into the module during registration time.

Solution: Ensure that all setup is complete before registering the
backing module.

Update regression test which would fail with this change.

Fixes flux-framework#4456
@chu11 chu11 mentioned this issue Aug 1, 2022
Merged
chu11 added a commit to chu11/flux-core that referenced this issue Aug 1, 2022
@chu11
content-sqlite,files,s3: register module later
1355f0f 
Problem: In the content-sqlite, content-files, and content-s3 modules,
the backing module is registered before setup of module services is
complete.  This can cause problems if the broker's content-cache
wants to make calls into the module during registration time.

Solution: Ensure that all setup is complete before registering the
backing module.

Update regression test which would fail with this change.

Fixes flux-framework#4456
@mergify mergify bot closed this as completed in #4458 Aug 2, 2022
chu11 added a commit to chu11/flux-core that referenced this issue Aug 8, 2022
@chu11
content-sqlite,files,s3: register module later
9e1024c 
Problem: In the content-sqlite, content-files, and content-s3 modules,
the backing module is registered before setup of module services is
complete.  This can cause problems if the broker's content-cache
wants to make calls into the module during registration time.

Solution: Ensure that all setup is complete before registering the
backing module.

Update regression test which would fail with this change.

Fixes flux-framework#4456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

content-sqlite,files,s3: register backing module after setup is complete chu11/flux-core
1 participant
@chu11