flux-top: initialize f character before drawing panes #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Mar 6, 2023
Problem: The initial draw of the summary pane shows "(null)" instead of "ƒ" or "f" because the top->f_char is not initialized until *after* the panes are created. Move the initial draw of top summary and job panes to after the f_char member is initialized.
Codecov Report
@@ Coverage Diff @@
## master #4982 +/- ##
==========================================
+ Coverage 83.06% 83.08% +0.01%
==========================================
Files 442 442
Lines 76079 76079
==========================================
+ Hits 63198 63211 +13
+ Misses 12881 12868 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The initial draw of the summary pane shows "(null)" instead of "ƒ" or "f" because the top->f_char is not initialized until after the panes are created.
Move the initial draw of top summary and job panes to after the f_char member is initialized.