-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
job-list: stats missing for configured queue #5688
Comments
The issue is easily observed by adding a queue and then noting that $ echo "[queues.batch]" | flux config load
$ flux queue list
QUEUE DEFAULTTIME TIMELIMIT NNODES NCORES NGPUS
batch inf inf 0-inf 0-inf 0-inf
$ flux job stats | jq .queues
[] |
seems like a good idea. One possible alternative, if a jobspec or jobspec-update has a queue mentioned, make sure it is job stats. This could handle the very rare case that a queue existed before, but no longer exists? ... I'm not sure this is worth the energy of doing though. |
That doesn't solve the case of a configured queue that has never had a job submitted to it (as in the example above) |
oh duh, you're right, it would only solve the bug solved by #5685. So it'd have to be both. |
Problem: Job queue stats are generated in job-list when a job is submitted into it. If a job queue never has a job submitted to it, no job stats exist for the queue. This isn't what users would expect, they should expect queue stats to be 0 for the queue. Solution: Read the flux config and initialize queue stats to 0 for any queues that have been configured. Fixes flux-framework#5688
Problem: Job queue stats are generated in job-list when a job is submitted into it. If a job queue never has a job submitted to it, no job stats exist for the queue. This isn't what users would expect, they should expect queue stats to be 0 for the queue. Solution: Read the flux config and initialize queue stats to 0 for any queues that have been configured. Fixes flux-framework#5688
Problem: Job queue stats are generated in job-list when a job is submitted into it. If a job queue never has a job submitted to it, no job stats exist for the queue. This isn't what users would expect, they should expect queue stats to be 0 for the queue. Solution: Read the flux config and initialize queue stats to 0 for any queues that have been configured. Fixes flux-framework#5688
The job-list module only includes stats for queues to which at least one job has been submitted. This means no stats will appear for a configured but unused queue, except in the case where a job is submitted to a queue and moved to another queue.
After a reload, job-list doesn't update stats while processing events from the eventlog, so no stats will appear for an unused queue even in this case.
It would perhaps be better to initialize zeroed queue stats for all configured queues, so even unused queues will appear in
flux job stats
output (which is a reasonable assumption a user of this interface or the corresponding RPC might have)The text was updated successfully, but these errors were encountered: