Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Fix forced dirty bit clear error #1133

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Jul 31, 2017

The function cache_entry_force_clear_dirty() should also destroy the
dirty waitqueue, as the entries in the waitqueue no longer matter
and it would prevent the cache entry from ever being reclaimed.

modules/kvs: Fix forced dirty bit clear error
The function cache_entry_force_clear_dirty() should also destroy the
dirty waitqueue, as the entries in the waitqueue no longer matter
and it would prevent the cache entry from ever being reclaimed.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 31, 2017

Codecov Report

Merging #1133 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   77.38%   77.33%   -0.06%     
==========================================
  Files         184      184              
  Lines       31886    31887       +1     
==========================================
- Hits        24675    24659      -16     
- Misses       7211     7228      +17
Impacted Files Coverage Δ
src/modules/kvs/cache.c 91.22% <100%> (+0.15%) ⬆️
t/mpi/hello.c 93.54% <0%> (-6.46%) ⬇️
src/common/libflux/ev_flux.c 97.56% <0%> (-2.44%) ⬇️
src/common/libflux/mrpc.c 85.15% <0%> (-1.18%) ⬇️
src/modules/kvs/kvs.c 62.67% <0%> (-0.79%) ⬇️
src/connectors/local/local.c 86.82% <0%> (-0.78%) ⬇️
src/common/libkvs/kvs.c 64.58% <0%> (-0.76%) ⬇️
src/common/libflux/dispatch.c 85.18% <0%> (-0.75%) ⬇️
src/common/libkvs/kvs_txn.c 60.5% <0%> (-0.64%) ⬇️
src/broker/overlay.c 71.67% <0%> (-0.35%) ⬇️
... and 13 more
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.03%) to 77.92% when pulling 252d105 on chu11:kvs_oom_corner_case_fix into 38fc4a6 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 31, 2017

Ah that makes sense. Thanks.

@garlick garlick merged commit ae10412 into flux-framework:master Jul 31, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.38%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +22.61% compared to 38fc4a6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 77.92%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.