build: Exit on error in autogen.sh plus other cleanup

[morrone]

Make autogen.sh exit after any of the commands fail.

Remove the "-I config" option from the autoreconf command
which appears to be redundant with either AC_CONFIG_AUX_DIR([config])
or AC_CONFIG_MACRO_DIR([config]) in the configure.ac file.

Stop removing autom4te.cache. We can't remember why we did that.

Resolves #1162

[coveralls]

Coverage increased (+0.2%) to 78.104% when pulling d0a3416 on morrone:autogen_changes into e2b5e8d on flux-framework:master.

[codecov-io]

Codecov Report

Merging #1163 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   77.75%   77.75%   -0.01%     
==========================================
  Files         158      158              
  Lines       29265    29266       +1     
==========================================
  Hits        22756    22756              
- Misses       6509     6510       +1

Impacted Files	Coverage Δ
src/common/libkvs/kvs_watch.c	86.34% <0%> (-0.89%)	⬇️
src/common/libutil/dirwalk.c	92.25% <0%> (-0.71%)	⬇️
src/broker/overlay.c	71.67% <0%> (-0.35%)	⬇️
src/broker/module.c	83.28% <0%> (-0.28%)	⬇️
src/common/libflux/message.c	81.17% <0%> (-0.24%)	⬇️
src/common/libcompat/handle.c	84.97% <0%> (+0.03%)	⬆️
src/common/libflux/handle.c	83.91% <0%> (+0.24%)	⬆️
src/common/libkvs/kvs.c	64.87% <0%> (+0.25%)	⬆️
src/modules/kvs/kvs.c	62.98% <0%> (+0.25%)	⬆️
src/common/libflux/future.c	89.1% <0%> (+0.49%)	⬆️

[garlick]

Thanks for the cleanup!

This needs to be rebased. While you're at it, any reason not to just do #!/bin/sh -e instead of adding the individual tests?

[morrone]

If we use -e, we could also use -x and not need any echo statements. But I don't really care either way.

[coveralls]

Coverage decreased (-0.01%) to 78.117% when pulling 2759907 on morrone:autogen_changes into e255d0f on flux-framework:master.

[grondo]

Bonked Travis on the noggin. One build hung after python tests (output stalled so Travis killed the build), so I restarted that build.

[grondo]

If we use -e, we could also use -x and not need any echo statements. But I don't really care either way.

This seems fine to merge now without changes. It fixes the issues in question -- if someone wants to enhance the script to use -x and -e in the future there's not reason not to submit another PR