Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: Rename internal "commit" API to "kvstxn" API #1348
Per discussion in #1344. I originally was going to do a lot more work before sending in a PR, but there were more "mini cleanups" to do a long the way than I realized, so I think it's a good stopping point for a PR. Per discussion in the issue, this PR handles the first bullet point I listed.
I chose to name the api
Since this hasn't been merged yet, I went ahead and pushed my changes to the "fence" data structure. This handles bullet #2.
The TBD I chose was "treq", standing for transaction request. I chose this instead of "txnreq" b/c with the "kvstxn" API, I thought have the word "txn" all over the place was a bit confusing.
Just like renaming the "commit" API, there were all these side cleanups I had to do as well.
@@ Coverage Diff @@ ## master #1348 +/- ## ========================================== - Coverage 78.54% 78.52% -0.02% ========================================== Files 162 162 Lines 29618 29619 +1 ========================================== - Hits 23264 23259 -5 - Misses 6354 6360 +6