libkvs: Require txn argument in flux_kvs_commit() and flux_kvs_fence() #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, just noticed a corner case. Wait till i re-push. |
chu11
force-pushed
the
issue1350
branch
2 times, most recently
from
6a65257
to
b75a42a
Compare
In wreck_pmi_barrier_enter(), remember to set f == NULL in the error path so the correct return code is returned.
In flux_kvs_commit() and flux_kvs_fence(), require txn to always be passed in. Return EINVAL if a NULL is passed in. Add unit tests to test for corner case. Adjust callers appropriately. Fixes flux-framework#1350
|
Just re-pushed with a corner case fix patch. As a note, I preserved behavior of |
|
That looks much nicer. Will merge when travis is done. |
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
+ Coverage 78.5% 78.51% +0.01%
==========================================
Files 162 162
Lines 29686 29690 +4
==========================================
+ Hits 23304 23312 +8
+ Misses 6382 6378 -4
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.