Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Extend JSC to add R_lite support #1485
This PR supports the
Also add some minor fixes along the way:
Add a very simple
@@ Coverage Diff @@ ## master #1485 +/- ## ========================================== - Coverage 78.72% 78.66% -0.06% ========================================== Files 164 164 Lines 30358 30405 +47 ========================================== + Hits 23900 23919 +19 - Misses 6458 6486 +28
@dongahn, this looks like it solves the problem, and I'm glad you added the test.
I think there are quite a few issues that shouldn't blow by without comment, such as
However, this code is consistent with hte rest of the library and I think we could merge it as is with the plan to create something new for the new execution system. Is that reasonable?