[asan] various test and core bug repairs toward asan testing

src/bindings/lua/lua-affinity/lua-affinity.c

@@ -55,8 +55,8 @@ static int lua_string_to_cpu_setp (lua_State *L, int index, cpu_set_t *setp)
      *  If string begins with 0x, 00, or contains long string of digits
      *   separated by ',', or cstr_to_cpuset() fails then try hex_to_cpuset().
      */
-    if ((memcmp (s, "0x", 2L) == 0)
-            || (memcmp (s, "00", 2L) == 0)
+    if ((strncmp (s, "0x", 2L) == 0)
+            || (strncmp (s, "00", 2L) == 0)
             || ((strchr (s, ',') - s) >= 8)
             || ((err = cstr_to_cpuset (setp, s)) && err != E2BIG)) {
         err = hex_to_cpuset (setp, s);

src/broker/test/attr.c

@@ -102,7 +102,7 @@ int main (int argc, char **argv)
      */
     val = attr_first (attrs);
     ok (val && !strcmp (val, "foo"),
-        "attr_first returned %s", val);
+        "attr_first returned foo");
     ok (attr_next (attrs) == NULL,
         "attr_next returned NULL");
     ok (attr_add (attrs, "foo1", "42", 0) == 0
@@ -112,19 +112,19 @@ int main (int argc, char **argv)
         "attr_add foo1, foo2, foo3, foo4 works");
     val = attr_first (attrs);
     ok (val && !strncmp (val, "foo", 3),
-        "attr_first returned %s", val);
+        "attr_first returned foo-prefixed attr");
     val = attr_next (attrs);
     ok (val && !strncmp (val, "foo", 3),
-        "attr_next returned %s", val);
+        "attr_next returned foo-prefixed attr");
     val = attr_next (attrs);
     ok (val && !strncmp (val, "foo", 3),
-        "attr_next returned %s", val);
+        "attr_next returned foo-prefixed attr");
     val = attr_next (attrs);
     ok (val && !strncmp (val, "foo", 3),
-        "attr_next returned %s", val);
+        "attr_next returned foo-prefixed attr");
     val = attr_next (attrs);
     ok (val && !strncmp (val, "foo", 3),
-        "attr_next returned %s", val);
+        "attr_next returned foo-prefixed attr");
     ok (attr_next (attrs) == NULL,
         "attr_next returned NULL");
 
@@ -134,28 +134,28 @@ int main (int argc, char **argv)
         "attr_add_active_int works");
     a = 0;
     ok (attr_get (attrs, "a", &val, NULL) == 0 && val && !strcmp (val, "0"),
-        "attr_get on active int tracks value: %s", val);
+        "attr_get on active int tracks val=0");
     a = 1;
     ok (attr_get (attrs, "a", &val, NULL) == 0 && !strcmp (val, "1"),
-        "attr_get on active int tracks value: %s", val);
+        "attr_get on active int tracks val=1");
     a = -1;
     ok (attr_get (attrs, "a", &val, NULL) == 0 && !strcmp (val, "-1"),
-        "attr_get on active int tracks value: %s", val);
+        "attr_get on active int tracks val=-1");
     a = INT_MAX - 1;
     ok (attr_get (attrs, "a", &val, NULL) == 0
         && strtol (val, NULL, 10) == INT_MAX - 1,
-        "attr_get on active int tracks value: %s", val);
+        "attr_get on active int tracks val=INT_MAX-1");
     a = INT_MIN + 1;
     ok (attr_get (attrs, "a", &val, NULL) == 0
         && strtol (val, NULL, 10) == INT_MIN + 1,
-        "attr_get on active int tracks value: %s", val);
+        "attr_get on active int tracks val=INT_MIN+1");
 
     ok (attr_set (attrs, "a", "0", false) == 0 && a == 0,
-        "attr_set on active int sets value: %d", a);
+        "attr_set on active int sets val=0");
     ok (attr_set (attrs, "a", "1", false) == 0 && a == 1,
-        "attr_set on active int sets value: %d", a);
+        "attr_set on active int sets val=1");
     ok (attr_set (attrs, "a", "-1", false) == 0 && a == -1,
-        "attr_set on active int sets value: %d", a);
+        "attr_set on active int sets val=-1");
     errno = 0;
     ok (attr_delete (attrs, "a", false) < 0 && errno == EPERM,
         "attr_delete on active attr fails with EPERM");
@@ -168,19 +168,19 @@ int main (int argc, char **argv)
         "attr_add_active_uint32 works");
     b = 0;
     ok (attr_get (attrs, "b", &val, NULL) == 0 && val && !strcmp (val, "0"),
-        "attr_get on active uin32_t tracks value: %s", val);
+        "attr_get on active uin32_t tracks val=0");
     b = 1;
     ok (attr_get (attrs, "b", &val, NULL) == 0 && !strcmp (val, "1"),
-        "attr_get on active uint32_t tracks value: %s", val);
+        "attr_get on active uint32_t tracks val=1");
     b = UINT_MAX - 1;
     ok (attr_get (attrs, "b", &val, NULL) == 0
         && strtoul (val, NULL, 10) == UINT_MAX - 1,
-        "attr_get on active uint32_t tracks value: %s", val);
+        "attr_get on active uint32_t tracks val=UINT_MAX-1");
 
     ok (attr_set (attrs, "b", "0", false) == 0 && b == 0,
-        "attr_set on active uint32_t sets value: %d", b);
+        "attr_set on active uint32_t sets val=0");
     ok (attr_set (attrs, "b", "1", false) == 0 && b == 1,
-        "attr_set on active uint32_t sets value: %d", b);
+        "attr_set on active uint32_t sets val=1");
     ok (attr_delete (attrs, "b", true) == 0,
         "attr_delete (force) works on active attr");
 
@@ -190,10 +190,10 @@ int main (int argc, char **argv)
         "attr_add_active_int FLUX_ATTRFLAG_IMMUTABLE works");
     c = 42;
     ok (attr_get (attrs, "c", &val, NULL) == 0 && val && !strcmp (val, "42"),
-        "attr_get returns initial value: %s", val);
+        "attr_get returns initial val=42");
     c = 43;
     ok (attr_get (attrs, "c", &val, NULL) == 0 && val && !strcmp (val, "42"),
-        "attr_get ignores value changes: %s", val);
+        "attr_get ignores value changes");
     errno = 0;
     ok (attr_delete (attrs, "c", true) < 0 && errno == EPERM,
         "attr_delete (force) fails with EPERM");

src/cmd/flux.c

@@ -67,7 +67,7 @@ static const char *default_cmdhelp_pattern (optparse_t *p)
 
 void usage (optparse_t *p)
 {
-    char *help_pattern;
+    char *help_pattern = NULL;
     const char *val = getenv ("FLUX_CMDHELP_PATTERN");
     const char *def = default_cmdhelp_pattern (p);
 
@@ -80,6 +80,7 @@ void usage (optparse_t *p)
     optparse_print_usage (p);
     fprintf (stderr, "\n");
     emit_command_help (help_pattern, stderr);
+    free (help_pattern);
 }
 
 static optparse_t * setup_optparse_parse_args (int argc, char *argv[])

src/common/libflux/mrpc.c

@@ -473,6 +473,7 @@ static flux_mrpc_t *mrpc (flux_t *h,
     if (rv < 0)
         goto error;
     nodeset_iterator_destroy (itr);
+    nodeset_destroy (ns);
     return mrpc;
 error:
     flux_mrpc_destroy (mrpc);

src/common/libkvs/test/kvs_eventlog.c

@@ -144,6 +144,7 @@ void bad_input (void)
     struct flux_kvs_eventlog *log;
     char *s;
     int i;
+    char buf[512];
 
     lives_ok ({flux_kvs_eventlog_destroy (NULL);},
               "flux_kvs_eventlog_destroy log=NULL doesn't crash");
@@ -191,7 +192,6 @@ void bad_input (void)
 
     /* decode bad events */
     for (i = 0; badevent[i] != NULL; i++) {
-        char buf[80];
         errno = 0;
         ok (flux_kvs_event_decode (badevent[i], NULL, NULL, 0, NULL, 0) < 0
             && errno == EINVAL,
@@ -206,7 +206,6 @@ void bad_input (void)
 
     /* decode bad logs */
     for (i = 0; badlog[i] != NULL; i++) {
-        char buf[512];
         errno = 0;
         ok (flux_kvs_eventlog_decode (badlog[i]) == NULL && errno == EINVAL,
             "flux_kvs_eventlog_decode log=\"%s\" fails with EINVAL",

src/common/libutil/read_all.c

@@ -65,14 +65,15 @@ ssize_t read_all (int fd, void **bufp)
     do {
         if (len - count == 0) {
             len += chunksize;
-            if (!(new = realloc (buf, len)))
+            if (!(new = realloc (buf, len+1)))
                 goto error;
             buf = new;
         }
         if ((n = read (fd, buf + count, len - count)) < 0)
             goto error;
         count += n;
     } while (n != 0);
+    ((char*)buf)[count] = '\0';
     *bufp = buf;
     return count;
 error: