python: improve Hostlist class indexing #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When slicing a Hostlist object, a Python list is returned, but it would be far more practical and efficient to return a new Hostlist instead. Also, this follows the example of Python list slicing, since indexing a list returns an element, but slicing returns a new list. Update the Hostlist index method to return a new Hostlist when a slice is used. Update the expand() method and one test accordingly.
Problem: It would be convenient to index a hostlist with an iterable, e.g. a tuple of values (`hl[1,5]`) or an idset (`hl[ids]`), but this is not currently supported. Support indexing a Hostlist object with any iterable, as long as the iterable only contains integral values.
Problem: No tests of the python Hostlist interface verify that iterable indexing works. Add a set of tests for iterable indexing, including indexing using an IDset and a test that an invalid iterable raises the appropriate exception.
Problem: The flux-resource utility has to iterate an idset to generate a new Hostlist, but now Hostlist supports direct indexing via an idset. Update the one case where a new Hostlist is constructed by idset in the flux-resource code.
Codecov Report
@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
- Coverage 83.10% 83.09% -0.01%
==========================================
Files 443 443
Lines 76176 76185 +9
==========================================
+ Hits 63303 63309 +6
- Misses 12873 12876 +3
|
|
Thanks! I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR improves the indexing of
Hostlistobjects byHostlistwhen more than one host is indexed, e.g. by slice (before, alistof hosts was returned)hl[1,3,5]and an idsethl[ids].