flux-job: improve EPERM error message #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
May 16, 2024
|
Thanks! Setting MWP |
Problem: When attaching to a job of another user, the error message flux-job: flux_job_event_watch_get: Operation not permitted is emitted by `flux job attach` which isn't helpful. Improve the error message to flux-job: Failed to attach to JOBID: That is not your job Fixes flux-framework#2852
Problem: No tests in the testsuite ensure that a sensible error is generated when a guest user attempts to `flux job attach` to a job they do not own. Add a test to t2500-job-attach.t.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5971 +/- ##
==========================================
+ Coverage 83.29% 83.32% +0.02%
==========================================
Files 515 515
Lines 83405 83407 +2
==========================================
+ Hits 69471 69497 +26
+ Misses 13934 13910 -24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just closes an old issue since the fix was simple enough.