Merge pull request #5971 from grondo/issue#2852

flux-job: improve EPERM error message
flux-framework · May 16, 2024 · 8a6eb0e · 8a6eb0e
2 parents a3cfb3b + 4149a9e
commit 8a6eb0e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/cmd/job/attach.c b/src/cmd/job/attach.c
@@ -1099,6 +1099,9 @@ void attach_event_continuation (flux_future_t *f, void *arg)
             goto done;
         if (errno == ENOENT)
             log_msg_exit ("Failed to attach to %s: No such job", ctx->jobid);
+        if (errno == EPERM)
+            log_msg_exit ("Failed to attach to %s: that is not your job",
+                          ctx->jobid);
         log_msg_exit ("flux_job_event_watch_get: %s",
                       future_strerror (f, errno));
     }

diff --git a/t/t2500-job-attach.t b/t/t2500-job-attach.t
@@ -255,4 +255,13 @@ test_expect_success 'attach: writing to stdin of closed tasks returns EPIPE' '
 	test_debug "cat pipe.out" &&
 	grep -i "Broken pipe" pipe.out
 '
+test_expect_success 'attach: EPERM generates sensible error' '
+	jobid=$(flux job last) &&
+	( export FLUX_HANDLE_USERID=42 &&
+	  export FLUX_HANDLE_ROLEMASK=0x2 &&
+	  test_must_fail flux job attach -vEX $jobid 2>eperm.err
+	) &&
+	test_debug "cat eperm.err" &&
+	grep -i "not your job" eperm.err
+'
 test_done