t/t0005-exec.t: Fix corner case in test for file not found #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should probably mention, of course one could just change my PATH that made me hit this issue. But in this particular case, the bad directory was part of the defaults on login, took me awhile to figure out the problem. So figured we could avoid the problem in the future. |
Current coverage is 71.52% (diff: 100%)@@ master #848 diff @@
==========================================
Files 157 157
Lines 26683 26683
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 19085 19085
Misses 7598 7598
Partials 0 0
|
grondo
approved these changes
Oct 13, 2016
chu11
force-pushed
the
t0005-exec.t-corner-case
branch
from
3bbdc96
to
cf4b643
Compare
|
fyi, rebased on current master and now running through travis |
The fake file 'nosuchprocess' does not have a relative or absolute path specified. So the file will be searched for in all directories in the user's PATH. If the user does not have access to one of the directories in their PATH, an EACCES error can occur instead of ENOENT, leading to a failed test. So put "./" in front of 'nosuchprocess' to ensure it is not searched for in PATH.
chu11
force-pushed
the
t0005-exec.t-corner-case
branch
from
cf4b643
to
1d9d613
Compare
|
Changes Unknown when pulling 1d9d613 on chu11:t0005-exec.t-corner-case into * on flux-framework:master*. |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake file 'nosuchprocess' does not have a relative or absolute path specified. So the file will be searched for in all directories in the users PATH. If the user does not have access to one of the directories in their PATH, an EACCES error can occur instead of ENOENT, leading to a failed test. So put "./" in front of 'nosuchprocess' to ensure it is not searched for in PATH.