Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add dependency on "all" to top-level make check #970

Merged
merged 2 commits into from
Feb 6, 2017
Merged

build: Add dependency on "all" to top-level make check #970

merged 2 commits into from
Feb 6, 2017

Commits on Feb 3, 2017

  1. build: Add dependency on "all" to top-level make check

    Many of flux-core's tests live down in subdirectories with
    the core that that it is testing.  However, some of those tests
    also have dependencies on other subdirectories higher up the
    source tree.  With the recursive Makefiles approach, there is
    no easy way to express that build dependency in a way that will
    actually trigger the build of the that dependency.  The following
    check-local rule, in conjunction with putting "." _first_ in this
    file's SUBDIRS, ensures that "all" is built before any of the
    recursive checks.
    
    "check-local" is the only way that was found to add a dependency to
    the "check" target.  But "make check" is a recursive operation by
    default, so the this dependency can only happen first if we also
    make "." the first subdirectory in the SUBDIRS list.
    
    Note that this approach will _only_ work at the top level of the
    source tree.  However, it seems likely that this is not the only
    place in the flux-core source tree when a make target needs to be
    run at a higher level of the tree in order to be successful.  This
    is probably an inevitable consequence of the using recursive makefiles
    and the design of the ordering dependencies in flux-core.
    
    This was tested to work with "make -j 32 check" as well.
    
    Fixes #399
    morrone committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    5d746e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e6fb94 View commit details
    Browse the repository at this point in the history