Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flux-sched to the latest KVS interface #252

Closed
SteVwonder opened this issue Jul 7, 2017 · 1 comment
Closed

Update flux-sched to the latest KVS interface #252

SteVwonder opened this issue Jul 7, 2017 · 1 comment

Comments

@SteVwonder
Copy link
Member

Looks like parts of flux-sched (at minimum the simulator) were still using the deprecated json-c KVS interface. flux-framework/flux-core#1100 replaces that with a jansson-based interface.

make[3]: Entering directory `/home/travis/build/flux-framework/flux-sched/flux-sched-0.3.0-45-gf5a7bcb/_build/sub/simulator'
  CC       libflux_sim_la-simulator.lo
../../../simulator/simulator.c: In function ‘pull_job_from_kvs’:
../../../simulator/simulator.c:209:5: error: implicit declaration of function ‘kvsdir_get_string’ [-Werror=implicit-function-declaration]
../../../simulator/simulator.c:218:5: error: implicit declaration of function ‘kvsdir_get_double’ [-Werror=implicit-function-declaration]
../../../simulator/simulator.c:227:5: error: implicit declaration of function ‘kvsdir_get_int’ [-Werror=implicit-function-declaration]
../../../simulator/simulator.c:233:5: error: implicit declaration of function ‘kvsdir_get_int64’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
@garlick
Copy link
Member

garlick commented Jul 7, 2017

Sorry about that! Will get a PR cooked up ASAP.

garlick added a commit to garlick/flux-sched that referenced this issue Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants