Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve footer code #222

Merged
merged 2 commits into from Feb 20, 2019
Merged

Improve footer code #222

merged 2 commits into from Feb 20, 2019

Conversation

Quy
Copy link
Member

@Quy Quy commented Feb 18, 2019

$footer_style is checked only once for if set.

@Quy Quy changed the title Refactor footer Improve footer code Feb 18, 2019
oldskool
oldskool approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@oldskool oldskool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small improvement, thanks 👍

franzliedke
franzliedke reviewed Feb 19, 2019
View reviewed changes
footer.php Outdated Show resolved Hide resolved
@franzliedke franzliedke merged commit 4dc4e10 into master Feb 20, 2019
@franzliedke franzliedke deleted the refactor-footer branch February 20, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzliedke franzliedke franzliedke left review comments

@oldskool oldskool oldskool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Quy @franzliedke @oldskool