-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize controller envFrom helm values #35
Comments
Without digging to deep into that. Just a question. Does the secret mount does not work her as well?
|
My understanding is that would not work because I cannot specify an environment variable within the controller for it to pull from the secret mount. Also I thought it might be more confusing to go a different route than what the flux documentation specifies. |
@dwerder - If there are no other questions, I am happy to create a pull request, but I believe I need someone to sign off first. Is that correct? Thanks! |
please open the PR you need to sign your commit for example |
Is your feature request related to a problem ?
If needing to use an Azure service principal to decrypt sops secrets, there doesn't currently exist an option to configure one via the helm values.
Describe the solution you'd like.
Following a similar approach used in the flux v1 helm chart, would like to propose these values exposed and the kustomize controller template updated (see https://github.com/MxNxPx/helm-charts/tree/kustomize-envFrom).
Updated these files:
Describe alternatives you've considered.
NONE
Additional context.
The following branch should be ready for submitting a PR if sign off is given: https://github.com/MxNxPx/helm-charts/tree/kustomize-envFrom
The text was updated successfully, but these errors were encountered: