Provide ability to specify kustomize controller envFrom values #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MxNxPx <MxNxPx@gmail.com>
Signed-off-by: MxNxPx <MxNxPx@gmail.com>
Signed-off-by: MxNxPx <MxNxPx@gmail.com>
… map for envFrom Signed-off-by: MxNxPx <MxNxPx@gmail.com>
Signed-off-by: MxNxPx <MxNxPx@gmail.com>
Signed-off-by: MxNxPx <MxNxPx@gmail.com>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de> Signed-off-by: MxNxPx <MxNxPx@gmail.com>
…is <MxNxPx@gmail.com> Signed-off-by: MxNxPx <MxNxPx@gmail.com>
|
for clean commit history please rebase master/main instead merge master/main and please squash you commits |
…x@gmail.com> Signed-off-by: michael <mxnxpx@gmail.com>
…arts into kustomize-envFrom
dwerder
requested changes
Dec 9, 2021
|
@dwerder - incorporated the changes you suggested. but in the event this still looks off, would you mind opening a new pull request if I close this one out? |
Signed-off-by: michael <mxnxpx@gmail.com>
|
@MxNxPx We can do that. |
|
closing this PR so it can be redone more cleanly. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
#35
Special notes for your reviewer:
Bumped up the chart version to 0.6.5. Testing performed included a helm template with no errors and a deployment using the envFrom secret helm value.
Checklist