-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated key 'metadata' #31
Conversation
@alexlee5354 thanks can you bump the helm-chart version ? then we can go |
@pierluigilenoci helm-docs and dco is missing in this PR :/ |
There is a checklist and maybe we should stick to that. |
@pierluigilenoci can you open a follow up |
Just to be specific, it just missed updating this line, right? helm-charts/charts/flux2/README.md Line 3 in 96743b5
|
you just need to execute helm-docs. Like described in the CONTRIBUTING.md. There is a reason for the checkboxes. |
What this PR does / why we need it:
Remove duplicated key 'metadata' in notification controller
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist