helm-docs #33
Merged
helm-docs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
You are changing the content of the chart. Which means the chart version needs to be bumped. See the details of the failed check. |
dwerder
reviewed
Dec 6, 2021
|
|
||
| # helm chart dependencies | ||
| flux2/charts/ | ||
| flux2-sync/charts/ |
There was a problem hiding this comment.
These are the folders where the helm package command generates the .tgz file.
For me make sense to "ignore" them to avoid inadvertently uploading files.
|
@dwerder think no Change in HelmChart so why the Check is running ? |
|
As i mentioned above. Even changing the README is a change in the chart and requires a minor version bump |
haarchri
approved these changes
Dec 7, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Fixes #31 (comment)
Special notes for your reviewer:
Checklist