Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Turn off the docker scan option completely. #2411

Closed
ysaakpr opened this issue Aug 28, 2019 · 9 comments · Fixed by #2753
Closed

Turn off the docker scan option completely. #2411

ysaakpr opened this issue Aug 28, 2019 · 9 comments · Fixed by #2753
Labels
enhancement FAQ Issues that come up a lot question

Comments

@ysaakpr
Copy link

ysaakpr commented Aug 28, 2019

Describe the feature
I use flux cd as purely for GitOps, which means, i update my kubernetes configurations through the CI pipeline and which at the end updates the git with the appropriate changes. But when i go through i can still see lots of logs saying its scanning all my docker images and ignoring them. Are there a way to turn off the pod scanning for docker images and stop those specific logs, which is actually confusing.

What would the new user story look like?
How would the new interaction with Flux look like? E.g.
0. User should able to turn on or off the docker scan options at a global level.

@ysaakpr ysaakpr added blocked-needs-validation Issue is waiting to be validated before we can proceed enhancement labels Aug 28, 2019
@stefanprodan
Copy link
Member

You can disable the image scanning with --registry-exclude-image=* see the FAQ for more details: https://docs.fluxcd.io/en/stable/faq.html#can-i-disable-flux-registry-scanning

@squaremo squaremo added FAQ Issues that come up a lot question and removed enhancement blocked-needs-validation Issue is waiting to be validated before we can proceed labels Aug 29, 2019
@squaremo
Copy link
Member

@ysaakpr Let us know if this works for you, and we can close the issue (or just close if you're happy).

@ysaakpr
Copy link
Author

ysaakpr commented Aug 29, 2019

Hi squaremo, it worked, but look through the code it's still scanning for all the deployed pods and matching with the given exclude glob. It would be an ideal case to disable the feature using another flag.

@squaremo
Copy link
Member

squaremo commented Sep 2, 2019

@ysaakpr I see what you mean, OK. Switching scanning off would involve some code detangling (and some design -- for instance, would it make sense to be able to switch scanning off, but still have automated upgrades? ). Logically, though, it is a completely reasonable desideratum.

@runningman84
Copy link

how can I use registry-exclude-image to exclude multiple images?

@hiddeco
Copy link
Member

hiddeco commented Sep 3, 2019

@runningman84 literally copied from the doc link posted above:

--registry-exclude-image=docker.io/*,quay.io/*

@max-lobur
Copy link

max-lobur commented Sep 16, 2019

Exclude works for me, but still, I would like to have a flag which disables registry scans completely. If wildcard matching syntax ever broken - I'm fucked up :(.
Registry on/off flag would be bulletproof.

@ysaakpr
Copy link
Author

ysaakpr commented Sep 18, 2019

I think for time being we can add a flag --disable-image-scan and apply the exclude image internally, and later we could add more specific changes to this feature

@2opremio
Copy link
Contributor

2opremio commented Jan 16, 2020

--registry-scanning=false was just added in #2745 , I will update the FAQ

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement FAQ Issues that come up a lot question
Projects
None yet
7 participants