Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid substitution issue in kustomize for azure credentials sync #1729

Merged
merged 1 commit into from Aug 19, 2021

Conversation

timja
Copy link
Contributor

@timja timja commented Aug 18, 2021

https://fluxcd.io/docs/components/kustomize/kustomization/#variable-substitution

Note that if you want to avoid var substitutions in scripts embedded in ConfigMaps or container commands, you must use the format $var instead of ${var}. All the undefined variables in the format ${var} will be substituted with string empty, unless a default is provided e.g. ${var:=default}.

https://cloud-native.slack.com/archives/CLAJ40HV3/p1629301869218600?thread_ts=1629215863.169600&cid=CLAJ40HV3

@stefanprodan
Copy link
Member

@timja thank you for this, can you please rebase with the main branch from upstream and force push.

Signed-off-by: Tim Jacomb <tim.jacomb@hmcts.net>
@timja
Copy link
Contributor Author

timja commented Aug 19, 2021

@timja thank you for this, can you please rebase with the main branch from upstream and force push.

done

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @timja 🏅

@stefanprodan stefanprodan merged commit 219ff2e into fluxcd:main Aug 19, 2021
@timja timja deleted the patch-1 branch August 19, 2021 10:42
@timja
Copy link
Contributor Author

timja commented Aug 19, 2021

ha our controller got further more fixes coming, PR incoming shortly

@timja
Copy link
Contributor Author

timja commented Aug 19, 2021

#1732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants