Avoid substitution issue in kustomize credentials sync #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Aug 19, 2021
manifests/integrations/eventhub-credentials-sync/_base/sync.yaml
Outdated
Show resolved
Hide resolved
|
We've tested this PR on our cluster and it fixes the issue |
|
@stefanprodan any chance of a merge? Thanks! |
timja
force-pushed
the
kustomize-substitute-fixes
branch
from
6a21216
to
164ddcf
Compare
stefanprodan
approved these changes
Aug 25, 2021
timja
force-pushed
the
kustomize-substitute-fixes
branch
from
164ddcf
to
5fda8bf
Compare
|
@stefanprodan would you be able to take a look please |
timja
force-pushed
the
kustomize-substitute-fixes
branch
from
5fda8bf
to
bba2c52
Compare
Signed-off-by: Tim Jacomb <tim.jacomb@hmcts.net>
timja
force-pushed
the
kustomize-substitute-fixes
branch
from
bba2c52
to
08f5ca3
Compare
stefanprodan
added
the
area/image-automation
|
build is green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Jacomb tim.jacomb@hmcts.net
Follow up to #1729