Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin envtest version #4689

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Pin envtest version #4689

merged 1 commit into from
Mar 25, 2024

Conversation

makkes
Copy link
Member

@makkes makkes commented Mar 25, 2024

This commit causes failures to install envtest, see kubernetes-sigs/controller-runtime#2720 for details.

This PR pins envtest to the latest version that still works.

[This
commit](kubernetes-sigs/controller-runtime@4c2442e)
causes failures to install envtest, see
kubernetes-sigs/controller-runtime#2720 for
details.

This change pins envtest to the latest version that still works.

Signed-off-by: Max Jonas Werner <mail@makk.es>
@stefanprodan stefanprodan added the area/testing Testing related issues and pull requests label Mar 25, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes

@stefanprodan stefanprodan merged commit c7db0c6 into main Mar 25, 2024
9 checks passed
@stefanprodan stefanprodan deleted the pin-envtest branch March 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants