Verify artifacts integrity #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Nov 12, 2021
stefanprodan
force-pushed
the
verify-artifact-checksum
branch
2 times, most recently
from
2166b58
to
e285033
Compare
hiddeco
reviewed
Nov 12, 2021
stefanprodan
force-pushed
the
verify-artifact-checksum
branch
from
e285033
to
697a587
Compare
After downloading an artifact, compute its checksum and verify that it matches the original checksum advertised by source-controller. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
verify-artifact-checksum
branch
from
697a587
to
459984c
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After downloading an artifact, compute its checksum and verify that it matches the original checksum as advertised by source-controller.
For backwards compatibility with source-controller v0.17.2, the checksum is computed with SHA1, on clusters with a newer source-controller we use SHA256.
Addresses fluxcd/source-controller#468