Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent snapshot drift when upgrading to API v2 #975

Merged
merged 1 commit into from
May 9, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented May 9, 2024

Mark Observation.OCIDigest as omitempty to avoid a snapshot drift when upgrading to API v2.

Before this fix, when updating the controller & CRDs from v0.x to v1.0 all releases were upgraded due to:

release not managed by controller: release not observed to be made for object

Whit this fix, the history snapshot remains unchanged, as the OCI digest empty string is no longer included in the calculation of the config digest.

Followup: #905

@stefanprodan stefanprodan added the backport:release/v1.0.x To be backported to release/v1.0.x label May 9, 2024
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit 461d45d into main May 9, 2024
6 checks passed
@stefanprodan stefanprodan deleted the fix-snaphot-drift branch May 9, 2024 08:23
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.0.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:release/v1.0.x To be backported to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants