Emit healthcheck event when Kustomization was not ready #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
ordovicia
force-pushed
the
emit-healthcheck-when-was-unready
branch
from
65e29ca
to
8b132d1
Compare
stefanprodan
added
the
area/kstatus
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Healthcheck can temporarily fail due to slow application startup, network failure, etc.
In this case, Flux emits an event of the failed healthcheck.
But when the healthcheck passes in another reconciliation, the current implementation does not emit a healthcheck event because the revision has not changed.
This PR fixes this behavior.
Flux will always emit a healthcheck event if a Kustomization was not ready in the previous reconciliation.