Index receivers using webhook path as key #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
reviewed
Apr 17, 2023
darkowlzz
reviewed
Apr 21, 2023
darkowlzz
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Did some testing to see if the index gets updated when the token changes and the index gets deleted when the receiver is deleted, and it does. Querying for the old index based webhook path results in 404.
Overall, it looks good to me.
Left one last minor comment.
stefanprodan
approved these changes
May 2, 2023
9 tasks
hiddeco
reviewed
May 3, 2023
hiddeco
approved these changes
May 3, 2023
There was a problem hiding this comment.
Much less computing and more precise reporting about endpoint availability in minimal LOC of changes, absolute great work @aryan9600 🥇
hiddeco
reviewed
May 3, 2023
Use `.status.webhookPath` as a key to index Receivers. Use this key while listing Receivers during the handling of a payload. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
hiddeco
approved these changes
May 3, 2023
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
.status.webhookPathas a key to index Receivers. Use this key while listing Receivers during the handling of a payload.This enables us to list only the Receivers required instead of listing all the Receivers in the entire cluster.