Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize: Implement envsubst strict mode #759

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan added area/kustomize Kustomize related issues and pull requests area/envsubst envsubst related issues and pull requests labels Apr 8, 2024
@stefanprodan stefanprodan requested a review from souleb April 8, 2024 10:19
@stefanprodan stefanprodan force-pushed the kustomize-envsubst-strict branch 2 times, most recently from 42ca1ba to 1990c03 Compare April 8, 2024 10:39
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a minor suggestion.

kustomize/kustomize_varsub.go Outdated Show resolved Hide resolved
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit f89e3b7 into main Apr 8, 2024
12 checks passed
@stefanprodan stefanprodan deleted the kustomize-envsubst-strict branch April 8, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/envsubst envsubst related issues and pull requests area/kustomize Kustomize related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants