libgit2: enforce context timeout #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
reviewed
May 27, 2022
pjbgf
force-pushed
the
ssh-context
branch
4 times, most recently
from
ed16205
to
bc011ee
Compare
pkg/git/libgit2/managed/ssh.go
Outdated
|
|
||
| // When context is nil, creates a new with internal SSH connection timeout. | ||
| if ctx == nil { | ||
| ctx, cancel = context.WithTimeout(context.TODO(), sshConnectionTimeOut) |
There was a problem hiding this comment.
Suggested change
| ctx, cancel = context.WithTimeout(context.TODO(), sshConnectionTimeOut) | |
| ctx, cancel = context.WithTimeout(context.Background(), sshConnectionTimeOut) |
Some scenarios could lead a goroutine to be running indefinetely within managed ssh. Previously between the two git operations, the reconciliation could take twice the timeout set for the Flux object. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scenarios could lead a goroutine to be running indefinetely within managed ssh.
Previously between the two git operations, the reconciliation could take twice the timeout set for the Flux object.
After the changes were introduced (after 10pm), the reconciliations became more stable:
