Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header banner to 2.2 release blog #1806

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Feb 9, 2024

This article is from 8 months ago, Flux has had two minor releases since GA. Preserve the banner in an HTML comment so we don't forget how this was done, in case we need to announce something again later.

FWIW, also some links to "August 2 webinar" on that page are no longer good, as weave.works has gone down for the count:

https://go.weave.works/Webinar-FluxCD-Positioned-for-Growth_LP.html

This article is from 8 months ago, Flux has had two minor releases since
GA. Preserve the banner in an HTML comment so we don't forget how this
was done, in case we need to announce something again later.

FWIW, links to "August 2 webinar" on that page are no longer good, as
weave.works has gone down for the count:

https://go.weave.works/Webinar-FluxCD-Positioned-for-Growth_LP.html

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
@kingdonb
Copy link
Member Author

kingdonb commented Feb 9, 2024

I don't know if it's just because I've been looking at the yellow bar at the top of the page for literally years that we said would definitely only stay there for a brief time, but this looks weird to me:

Screenshot 2024-02-09 at 9 39 55 AM

The spacing doesn't look wrong in any specific way that I can quantify, except for "that yellow bar left a huge margin here before and it's gone now" - could use some feedback before we merge this.

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
@kingdonb
Copy link
Member Author

kingdonb commented Feb 9, 2024

We might want to review both of these links in the blog post that isn't removed by this pr:

  [Flux support page](/support/#commercial-support) and this
  [August 2 webinar](https://go.weave.works/Webinar-FluxCD-Positioned-for-Growth_LP.html)
  on Flux 2.0-specific support.

https://fluxcd.io/support/#commercial-support

I haven't found any trace of the 2.0 release webinar on WeaveworksInc Youtube channel or on CNCF, this link is also bad:

- Watch our [CNCF webinar on Flux 2.0](https://community.cncf.io/events/details/cncf-cncf-online-programs-presents-cncf-on-demand-webinar-flux-20-what-you-need-to-know/),

The correct link is - https://www.cncf.io/online-programs/cncf-on-demand-webinar-flux-2-0-what-you-need-to-know/

but it doesn't have any evidence of the video, and I don't find anything with that title on the CNCF channel. I wonder if this webinar was cancelled.

@stefanprodan
Copy link
Member

@kingdonb we need to remove WW from the support page completely.

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
Some links (docs.gitops.weave.works) are still valid, and OSS Weave
GitOps still should be perfectly viable if someone will maintain it, so
I will leave all the links here for now. But this removes any direct
links to weave.works or go.weave.works as they are all down now.

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
@kingdonb
Copy link
Member Author

kingdonb commented Feb 9, 2024

Removed any mention of Weaveworks in the present tense from support and ecosystem pages. The Weave GitOps OSS may get a new maintainer, as one community member already volunteered to fix some kstatus issues, it could happen:

weaveworks/weave-gitops#4192

I think we should leave Weave GitOps but leave behind Weave GitOps Enterprise, as the company is gone and there is no way to license it anymore. Let me know if this should go in a separate PR 👍

@stefanprodan
Copy link
Member

Let replace GA with "What's new in Flux v2.2" and a link to https://fluxcd.io/blog/2023/12/flux-v2.2.0/

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
@kingdonb kingdonb changed the title Remove link to Flux 2.0 Generally Available blog Update header banner to 2.2 release blog Feb 10, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb 🎖️

@stefanprodan stefanprodan added the backport:v2-2 To be backported to v2-2 label Feb 11, 2024
@stefanprodan stefanprodan merged commit f8f75b3 into main Feb 11, 2024
6 checks passed
@stefanprodan stefanprodan deleted the remove-ga-notice branch February 11, 2024 08:03
@fluxcdbot
Copy link
Member

Successfully created backport PR for v2-2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v2-2 To be backported to v2-2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants