Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting openai/gym's foundation classes to Gym.jl #5

Closed
kraftpunk97-zz opened this issue Mar 23, 2019 · 5 comments
Closed

Porting openai/gym's foundation classes to Gym.jl #5

kraftpunk97-zz opened this issue Mar 23, 2019 · 5 comments

Comments

@kraftpunk97-zz
Copy link
Contributor

Hi. I just wanted to get an opinion on porting openai/gym's foundational classes (Space, Env, etc) to Gym.jl and then building additional environments atop these base classes. My reasoning is that for someone who is coming from using openai/gym, transitioning to Gym.jl will be effortless, because they'd already be familiar with underlying structure of the package.

@tejank10
Copy link
Contributor

That's a good idea. A structured way to represent observation and action space is currently required.

@kraftpunk97-zz
Copy link
Contributor Author

Cool. I'll start working on it right away.

@kraftpunk97-zz
Copy link
Contributor Author

I wanted to know if for certain action spaces we should switch to 0-based indexing or stick with 1-based indexing. For example, should Discrete spaces begin with 0 or with 1?

@tejank10
Copy link
Contributor

Beginning with 1 would make it more julia-like.

@kraftpunk97-zz
Copy link
Contributor Author

Closing Issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants