Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case: Updating Scenario #60

Closed
lvanvugt opened this issue Oct 5, 2020 · 4 comments
Closed

Use Case: Updating Scenario #60

lvanvugt opened this issue Oct 5, 2020 · 4 comments
Assignees
Labels
version A To be picked up right away
Milestone

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Oct 5, 2020

The following flowchart shows the use case:

Use Case (#60) - Updating Scenario

Exceptions

  • Non-alphabetical or non-numerical characters should not be ported to test function name (see also Use Case: Adding Scenario #38)
  • Scenario description should not have unlimited length as AL function names have a max length of 120 characters (see also Use Case: Adding Scenario #38)
    • I suggest to build logic that checks allowed length in Scenario description based on text with "to be removed" non-alphabetical or non-numerical characters

Settings

@DavidFeldhoff
Copy link
Collaborator

@martonsagi I'm done with my changes on this one, but there are some small issues which need to be fixed by you:

  • "Are you sure you want to update this scenario?" -> No -> New value stays in textbox (or it's just a refreshing issue as if i reopen the scenario it has the old value again)
  • I'm triggered on each keypress. The given/when/thens instead are only triggered if I leave the field. Could you change that to make it more consistent?

@martonsagi
Copy link
Collaborator

Value update should be ok now. Keypress triggers have been extended with a reasonable timeout to be triggered again.

@lvanvugt lvanvugt assigned lvanvugt and unassigned martonsagi Nov 2, 2020
@DavidFeldhoff
Copy link
Collaborator

@martonsagi it works much smoother now, thanks!
But the first issue I mentioned in my previous post still exists:
Currently:
Change Scenario -> Do you want to update? -> No -> The new value (which wasn't confirmed) remains in the field.
Expected:
Change Scenario -> Do you want to update? -> No -> The old value is placed again in the textbox

@DavidFeldhoff
Copy link
Collaborator

I made it explicit here #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version A To be picked up right away
Projects
None yet
Development

No branches or pull requests

3 participants