Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case: Adding Scenario #38

Closed
lvanvugt opened this issue Jul 29, 2020 · 6 comments
Closed

Use Case: Adding Scenario #38

lvanvugt opened this issue Jul 29, 2020 · 6 comments
Assignees
Labels
version A To be picked up right away
Milestone

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Jul 29, 2020

The following flowchart shows the use case:

Use Case (#38) - Adding Scenario

Exceptions

  • Non-alphabetical or non-numerical characters should not be ported to test function name
  • Scenario description should not have unlimited length as AL function names have a max length of 120 characters
    • I suggest to build logic that checks allowed length in Scenario description based on text with "to be removed" non-alphabetical or non-numerical characters

Settings

  • Make setting possible that user can set max length to Scenario description himself

Update 20201005

In the previous version of Add Scenario the Initialize helper function was not added. This has been updated on the flowchart. The basic structure of the Initialize helper function should be:

local procedure Initialize()
var
    LibraryTestInitialize: Codeunit "Library - Test Initialize";
begin
    LibraryTestInitialize.OnTestInitialize(Codeunit::<name of test codeunit>);

    if IsInitialized then
        exit;

    LibraryTestInitialize.OnBeforeTestSuiteInitialize(Codeunit::<name of test codeunit>);

    IsInitialized := true;
    Commit();

    LibraryTestInitialize.OnAfterTestSuiteInitialize(Codeunit::<name of test codeunit>);
end;

The isInitialize variable is a global Boolean.

@lvanvugt lvanvugt added the version B Next to be picked up (but needs probably some detailing) label Jul 29, 2020
lvanvugt pushed a commit that referenced this issue Jul 29, 2020
@DavidFeldhoff DavidFeldhoff added version A To be picked up right away and removed version B Next to be picked up (but needs probably some detailing) labels Sep 13, 2020
@lvanvugt
Copy link
Contributor Author

@DavidFeldhoff no commits related to this issue?

lvanvugt pushed a commit that referenced this issue Sep 24, 2020
lvanvugt pushed a commit that referenced this issue Sep 24, 2020
This was referenced Sep 25, 2020
@DavidFeldhoff
Copy link
Collaborator

Fixed in
4bd3fbf#diff-f267418653192133529f152c33dd6450R21
I'll assign it to you for testing Luc, as my tasks are finished so far. If you find some bugs: Keep them :)
No, if you find them, assign them to me, but I think the major part here is done, so it's better assigned to you, I think

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Oct 5, 2020

@DavidFeldhoff as mentioned on #46 this scenario needs to be extended as the Initialize helper functions needs to be added if it does not exist yet in the test codeunit. I will update the initial description of this post above (including the flowchart).

@DavidFeldhoff
Copy link
Collaborator

@martonsagi

  • Use setting to limit scenario description in UI

@DavidFeldhoff
Copy link
Collaborator

Short note: This one is nearly ready for testing. After #44 is solved, it should work just fine.

@lvanvugt lvanvugt assigned lvanvugt and unassigned martonsagi and DavidFeldhoff Nov 2, 2020
@lvanvugt
Copy link
Contributor Author

Tested and OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version A To be picked up right away
Projects
None yet
Development

No branches or pull requests

3 participants