Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case: Adding Feature #61

Closed
lvanvugt opened this issue Oct 5, 2020 · 4 comments
Closed

Use Case: Adding Feature #61

lvanvugt opened this issue Oct 5, 2020 · 4 comments
Assignees
Labels
version A To be picked up right away
Milestone

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Oct 5, 2020

The following flowchart shows the use case:

Use Case (#61) - Adding Feature

Exceptions

  • Non-alphabetical or non-numerical characters should not be ported to test codeunit name
  • As AL codeunit names have a max length of 30 characters we should restrict the length of feature description to this length for the time being
    • I suggest to build logic that checks allowed length in Scenario description based on text with "to be removed" non-alphabetical or non-numerical characters

Settings

  • In later version we might consider setting(s) allows that user somehow to manage length of feature description
@DavidFeldhoff
Copy link
Collaborator

@martonsagi

  • Hardcode the 30 characters limitation in the Feature description
  • Enable to add a new feature and send the following values in the messageUpdate: State = New, Type = Feature, newValue = Feature description entered by the user.

I'll add a new file on my own and add it under the folder specified in the settings.

martonsagi added a commit that referenced this issue Nov 1, 2020
@lvanvugt lvanvugt assigned lvanvugt and unassigned martonsagi and DavidFeldhoff Nov 2, 2020
@lvanvugt
Copy link
Contributor Author

@DavidFeldhoff, it seems to me that this Use Case: Adding Feature is far from ready.

When adding a new feature in Features pane, by creating a new text box and entering a name it:

  • an extra control with same descriptions is appearing
  • the codeunit created:
    • does have id 0 (would expects it to from id range in app.json
  • is not formatted, cannot be formatted, and has a lot of unwanted commas
    codeunit 0 "New Feature"{, Subtype = Test;,, trigger OnRun(), begin, // [Feature] New Feature, end;,, [Test], local procedure NewTestProcedure(), // [Feature] New Feature, begin, // [Scenario #0001] New Test Procedure, end;,}

@lvanvugt lvanvugt assigned DavidFeldhoff and unassigned lvanvugt Nov 21, 2020
lvanvugt pushed a commit that referenced this issue Nov 21, 2020
DavidFeldhoff added a commit that referenced this issue Nov 22, 2020
@DavidFeldhoff
Copy link
Collaborator

Hi Luc, I agree there were some issues. I fixed it on the backend-site, but the extra control with the same description has to be fixed by @martonsagi
Marton, can you have a look at it?
And regarding the object ID: I added a solution which is working for now, but I'd like to add a API to the extension of Andrzej (AZ AL Dev Tools). He has a more robust solution to get the next codeunit ID for his wizards. Or do you have something similar in place Marton in your AL Studio extension?

@DavidFeldhoff
Copy link
Collaborator

Maybe one more info: in the latest commit I pushed changes that worked in my easiest tests, but I haven't tested it yet enough to say it has a "ready" status ;)
But I still pushed the changes as Marton can step in now to fix the other bug.

@lvanvugt lvanvugt added the help wanted Extra attention is needed label Dec 28, 2020
martonsagi added a commit that referenced this issue Jan 26, 2021
lvanvugt added a commit that referenced this issue Jan 30, 2021
@lvanvugt lvanvugt removed the help wanted Extra attention is needed label Jan 30, 2021
@lvanvugt lvanvugt added this to the beta release milestone Jan 31, 2021
@lvanvugt lvanvugt assigned DavidFeldhoff and unassigned martonsagi Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version A To be picked up right away
Projects
None yet
Development

No branches or pull requests

3 participants