Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case: Removing Feature #62

Closed
lvanvugt opened this issue Oct 5, 2020 · 15 comments
Closed

Use Case: Removing Feature #62

lvanvugt opened this issue Oct 5, 2020 · 15 comments
Assignees
Labels
version A To be picked up right away
Milestone

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Oct 5, 2020

The following flowchart shows the use case:

Use Case (#62) - Removing Feature

Note

At this moment there is a one-to-one relation between a feature and a test codeunit. ATDD.TestScriptor cannot handle multiple features in one test codeunit. The consequence is that removing a feature is as simple as removing a whole codeunit

Exceptions

Settings

  • Make setting possible that user can disable confirm on removing test codeunit
@lvanvugt lvanvugt added the version A To be picked up right away label Oct 5, 2020
DavidFeldhoff added a commit that referenced this issue Oct 31, 2020
@lvanvugt
Copy link
Contributor Author

lvanvugt commented Nov 2, 2020

UI part needs to be finished.

@lvanvugt lvanvugt assigned martonsagi and unassigned DavidFeldhoff Nov 2, 2020
martonsagi added a commit that referenced this issue Nov 15, 2020
martonsagi added a commit that referenced this issue Nov 15, 2020
@martonsagi
Copy link
Collaborator

@DavidFeldhoff I changed the UI parts, but somehow the backend does not find the Scenario function to be deleted and I get undefined errors back. Maybe it's my test project, can you check it?

Previously, I sent the NewValue instead of OldValue, but I still get the error after fixes.

@DavidFeldhoff
Copy link
Collaborator

I'll have a look at it tomorrow, thank you.

@DavidFeldhoff
Copy link
Collaborator

@martonsagi I tested it with your bc-department project, but I couldn't reproduce the errors. Can you please give me some more detailed repro steps to figure out the issue?

@DavidFeldhoff DavidFeldhoff added the help wanted Extra attention is needed label Nov 22, 2020
martonsagi added a commit that referenced this issue Jan 26, 2021
@lvanvugt
Copy link
Contributor Author

lvanvugt commented Jan 30, 2021

This seems not to work.

When deleting a feature:

  1. I do not get a dialog asking me whether I want to delete the feature
  2. The line(s) relating to the feature is/are not removed from the ATDD.TestScriptor page, but
  3. The codeunit file remains

See test scenarios

No. Feature Scenario
0098 Removing Feature Remove Feature
0099 Removing Feature Remove Feature step 2a

in atdd-test-scenarios-and-results.xlsx

lvanvugt added a commit that referenced this issue Jan 30, 2021
@lvanvugt lvanvugt removed the help wanted Extra attention is needed label Jan 30, 2021
@lvanvugt lvanvugt added this to the beta release milestone Jan 31, 2021
@DavidFeldhoff
Copy link
Collaborator

Works with 784ed01.
If a feature is inside multiple files, then it checks if a file consists of only this one feature. If that's the case, then the whole file will be deleted.
If the file consists only partially of the feature, then only the test methods of that feature will be deleted.

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Feb 9, 2021

It seems not to do what you describe, @DavidFeldhoff, i.e. delete the codeunit file when this contains only one feature.

Delete Feature does not remove file (Use Case 62)

@DavidFeldhoff
Copy link
Collaborator

What you're doing there is that you remove a scenario - not the feature itself.
If you'd open the feature pane and then hit the trash-button there, then this file would be deleted.
That's how it is implemented now. Would you like it to change?

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Feb 9, 2021

I must have been sleeping. Will have a look again. Thanx and apology.

@DavidFeldhoff
Copy link
Collaborator

See here how it should work
removeFeature

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Feb 18, 2021

Tested and not (fully) OK

  • No dialog asking the user whether the Feature should be removed
  • In case of multiple features in one codeunit no dialogs asking to move helper functions
  • Feature tag in OnRun is not removed when multiple features in one test codeunit

lvanvugt added a commit that referenced this issue Feb 18, 2021
lvanvugt added a commit that referenced this issue Feb 18, 2021
lvanvugt added a commit that referenced this issue Feb 18, 2021
@lvanvugt lvanvugt assigned DavidFeldhoff and unassigned martonsagi Feb 18, 2021
DavidFeldhoff added a commit that referenced this issue Mar 9, 2021
@DavidFeldhoff
Copy link
Collaborator

This should be fixed now. @lvanvugt: Time for testing ;)

@lvanvugt
Copy link
Contributor Author

Hope to find some time this weekend to test it. This is loaded including the start of the project for the 2nd edition of my book. ;-)

lvanvugt added a commit that referenced this issue Mar 19, 2021
lvanvugt added a commit that referenced this issue Mar 19, 2021
@lvanvugt
Copy link
Contributor Author

We're getting close.

2 out of 3 scenarios do work.

When deleting a FEATURE that's spread over multiple (2) codeunits, they are not removed. See scenario 0106, that fails.

  • "Same Feature" is removed from Features pane in ATTD.TestScriptor page, so this is OK
  • But the related files are not removed and the test scenarios in it are still displayed in the TestScriptor pane
No. Feature Scenario
0098 Removing Feature Remove Feature (only one in one codeunit)
0099 Removing Feature Remove Feature (only one in one codeunit) step 2
0103 Removing Feature Remove Feature (two in one codeunit)
0104 Removing Feature Remove Feature (two in one codeunit) step 2
0105 Removing Feature Remove Feature (two in two codeunits)
0106 Removing Feature Remove Feature (two in two codeunits) step 2

in atdd-test-scenarios-and-results.xlsx

@lvanvugt lvanvugt assigned DavidFeldhoff and unassigned lvanvugt Mar 19, 2021
lvanvugt added a commit that referenced this issue Mar 19, 2021
@lvanvugt
Copy link
Contributor Author

Retested, together with David (important requirement ;-) it is working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version A To be picked up right away
Projects
None yet
Development

No branches or pull requests

3 participants