Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add difficulty level select function #18

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

cyblue9
Copy link
Collaborator

@cyblue9 cyblue9 commented Oct 25, 2018

Hi, @flxbe !

I created difficulty level select function.
After intro, It promote for player to select difficulty level.

2018-10-25 22 46 18

Change the value of the invaders_shoot_cycles variable according to the selected difficulty level.

example1(easy level):
2018-10-25 22 54 07

example2(hard level):
2018-10-25 22 54 50

What do you think?

@flxbe
Copy link
Owner

flxbe commented Oct 27, 2018

Very nice feature!

I am only available on my phone for the next days. As soon as I have access to my laptop I will review the PR.

@cyblue9 cyblue9 force-pushed the feature/add_select_difficulty_level branch from ea83b89 to 85cab10 Compare October 27, 2018 07:30
@flxbe
Copy link
Owner

flxbe commented Oct 27, 2018

Do you have any additional feature ideas or comments on the project? During the next days, I will create a few issues for the features I still have in mind.

I am currently pretty occupied with my master's thesis up to December. After this, I could imagine investing a little more time. Do you plan to also spent more time on this project in the future? If so, we should probably talk about a mid-term direction we are both happy with.

@cyblue9
Copy link
Collaborator Author

cyblue9 commented Oct 27, 2018

I love assembly, and I want to write code more!
so, I want to spent more time on this project in the future.

I have some feature idea.

Other than this project

  • Creating other games in assembly (And creating games pack)
  • Creating Educational tools of assembly(Because, many young people want to understand assembly but they think that it is difficult to understand assembly in japan(maybe around the world), so Educational tools that to learn by writing code are very useful for them)

Your code is nice and there are many things to learn!
Let's do the project for a long time!

@flxbe flxbe mentioned this pull request Oct 29, 2018
@flxbe flxbe merged commit a0ffca6 into flxbe:master Oct 29, 2018
@cyblue9 cyblue9 deleted the feature/add_select_difficulty_level branch October 31, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants