Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filament v3 Performance Optimization AND Ignore new line differences during test #32

Merged
merged 6 commits into from
Apr 7, 2024
Merged

Filament v3 Performance Optimization AND Ignore new line differences during test #32

merged 6 commits into from
Apr 7, 2024

Conversation

KTanAug21
Copy link
Contributor

@KTanAug21 KTanAug21 commented Apr 3, 2024 •
edited
Loading

What:

Improve Filament v3 Panel Performance by running optimization commands
Improve test run from GenerateCommandTest.php by:
Allow overriding of reference files by checking if proper env var value set
Creating a new test case to check whether "special snippets" are included in generated files

Why:
This CARD

Change Summary:

  1. Scan for filament version in composer.json file
  2. Run Filament prod-cache commands in Dockerfile if filament v3 and above detected
  3. Revise GenerateCommandTest to include logic for overriding reference files with generated file content based on env variable
  4. Create filament_v3 Snippets subfolder to test changes for Filament v3 support. This is included in the new test case because changes from Filament v3 support include "special snippets" that should be included in Dockerfiles generated for each "Supported Base folder"

1. Scan for filament version in composerjson file
fc40e21 
2. Run Filament prod-cache commands in Dockerfile if filament v3 and above detected
3. Revise GenerateCommandTest to ignore newline differences when checking if reference and generated files match
4. Create tests for laravel versions 10below and 11 for: filament_v3 support, AND filament_below_support_which_does_not_iclude_changes_for_v3_support
@KTanAug21 KTanAug21 marked this pull request as draft April 3, 2024 22:47
Kathryn Anne S Tan added 2 commits April 5, 2024 01:32
Install dotenv, include logic for overrding reference file with gener…
2bb23f2 
…ated content, override Dockerfile references for previous tests
Detect laravel version from composer.json file, Create testcase for c…
f016c60 
…hecking whether special snippets get included in templates generated, create Snippets folder to contain "special snippets config"
@KTanAug21 KTanAug21 marked this pull request as ready for review April 5, 2024 02:07
Kathryn Anne S Tan added 3 commits April 7, 2024 20:25
Finalize the changes to the new testcase for verifying snippets are p…
3d6b0ee 
…roperly added to a specific template thanks to some package detected. i.e, filament cache commands should be available in the Dockerfiles generated when v3 is detected
Include a new test case to test that special snippets are added to th…
7d1e4a6 
…e generated files given the detection of specific packages; Include details of the two test cases in README.me
Revise README.md to point to adding Test cases for possible PR requests
84f1a86
@KTanAug21 KTanAug21 merged commit 3e88b46 into main Apr 7, 2024
2 checks passed
@KTanAug21 KTanAug21 linked an issue Apr 7, 2024 that may be closed by this pull request
Support for FilamentPHP #16
Closed
@KTanAug21
Copy link
Contributor Author

Closes #16

@KTanAug21 KTanAug21 deleted the filament_support branch April 7, 2024 20:33
@KTanAug21 KTanAug21 mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for FilamentPHP
1 participant
@KTanAug21