-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hyd): Nose wheel steering and separate hand tiller axis #6187
Conversation
This PR will require a lot of testing and probably tuning of the ROLLOUT for Autoland. |
Oh yeah tests and more tests on this one :s We'll see if plane is usable as a start though.... I guess right now you only rely on rudder output for rudder and nose steering? We can imagine having a separate output from autoland just for steering that can kicks in at lower speeds and if rudder alone can't keep the center? |
We will see down the road, yes. I just wanted to highlight it for the moment so it's not forgotten. |
I have two questions:
I need to see how my spare time is, but then I will do changes to the AP so that we do not need to retune everything (I will interpret the output of the AP and split the signal depending on speed into rudder and nosewheel). |
I think the best way to do this would be for you to create a new LVAR that the steering system just adds to the requested position. I think it all works pretty well in "realistic mode", so you can do whatever you need with rudder like before, and just adding up to 6 degrees in your AP demand will turn the steering accordingly. Main issue right now is I totally fail to make it work correctly in "replicate the old sim behaviour"..... So that's a main problem as probably a lot of people just don't want a tiller. So until we can find a way to make the two modes work correctly don't spend too much time on this... |
Most of functional stuff planned is in and usable in last build artifact. If possible I'd need as many tests as possible and feedback about how the new handling feels, as this is pretty much a game changer compared with previous taxi behaviour. Remaining is a lot of code cleaning on the lib.rs low level hacks, and also tests on the AP roll out behaviour to see if we need a mandatory AP change or if it can wait for a dedicated PR. |
flybywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/model/A320_NEO.xml
Outdated
Show resolved
Hide resolved
flybywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/model/A320_NEO_INTERIOR.xml
Outdated
Show resolved
Hide resolved
Tried this PR and it’s great fun to taxi around with a tiller axis! |
f280860
to
a4cd34f
Compare
38ed584
to
47bc8ba
Compare
I‘m using the feature for a while now and it works really good. For me it‘s ready to go. |
Tested during writing the docs page. We should have at least 1 or 2 full tests though. |
Quality Assurance Trainee Report Discord : Systemfalter# 0698 Testing Process: Negatives: Testing Results: Conclusions: |
Quality Assurance Tester Report Discord : Calo#6816 Testing Process: PART 1 - PASSED
PART 2 - PARTIALLY? PASSED
PART 3 I´ve not been able to test this part since I have no tiller axis and it would be very difficult to taxi and made the required tests with keyboard buttons. Negatives: Pedal disconnect button works with Tiller setting disabled?? Testing Results: Passed Conclusions: Super cool feature, FBW really need it. Everything works as intended, but I only doubt about that small thing mentioned above. |
Quality Assurance Tester Report Discord: Cdr_Maverick#6475 Testing Process: Negatives: Testing Results: Passed with minor issue - but in my opinion it's ok like this Conclusions: LGTM Protocol:
|
…lybywiresim#6187)" This reverts commit 26af4f4.
…lybywiresim#6187)" This reverts commit 26af4f4.
…lybywiresim#6187)" This reverts commit 26af4f4.
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems Co-Authored-By: Erick Torres <30361843+ErickSharp@users.noreply.github.com>
…lybywiresim#6187)" This reverts commit 26af4f4. fix systems
Fixes #4791 Fixes #5851 Fixes #4947
Summary of Changes
Challenge: Plane rudder to steering link is hard coded in msfs and can't be disabled, thus it is impossible to implement steering tiller handle function properly.
This PR uses a "hack" to properly allow total separation between plane rudder and nose steering. As msfs internally adds rudder action to steering, we just substract expected rudder action by msfs from the steering angle we really request.
A new custom hydraulic steering is added. Its implementation is not affected by the hack used, so only the msfs interface part contains the hacky part, and will be easily removed when issue solved by Asobo.
Known issues caused by the hack:
-Full tiller one way and rudder the opposite way can move the steering even without hydraulic power
-Full rudder action can overcome to some extent our system implementation: you can move a bit the steering even with no hydraulic power, as msfs will turn the wheel even when our internal implementation is not moving at all.
Modifying steering animation so it shows our internal system state will mask those issues and allow for perfect visual behaviour. But it can cause strange plane rotation behaviour when above mentioned issues will be triggered.
Credits to @tracernz for the fixing of broken default steering animation!!!
Features:
BINDING NOTES (function -> ingame binding):
Tiller axis -> MIXTURE 4 AXIS (-100% to 100%)
Tiller pedal disconnect -> TOGGLE WATER RUDDER
Tiller keyboard + (if no axis used) -> INCREASE STEERING
Tiller keyboard - (if no axis used) -> DECREASE STEERING
Note that all study level details about activation and steering will be missing, let's keep this as simple as possible for a first try.
In further PR, we'll add details such as the nose wheel to be turned in flight +/- 2.5° by BSCU self test and declare a fault if it's not moving.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
As this PR makes a huge change on ground behaviour, please give any good or bad feedback you have in mind so we can cross check this with type rated pilots. Taxiing WILL require more attention as the real plane does. Turn the tiller handle slowly to follow wheel steering action will help to anticipate turn in / turn out, as the steering will take time to go back to center.
IMPORTANT NOTE:
Visual animation is linked to our new hydraulic system physical position. In case of max pedal rudder input, MSFS might be able to turn the wheel internally WHATEVER our system implementation state. This means you won't see nose wheel moving but it turns behind the scene in MSFS, which will make the plane acting differently from what the visual nose steering is indicating. Nothing we can do about this until an ASOBO fix.
That said, any strange movement of nose steering indicates an issue in our system implementation and has to be noted and corrected.
The fun begins!! Let's divide testing in 3 parts:
Steering hydraulic system implementation
Legacy mode (EFB settings / Sim options / Tiller setting disabled)
Realistic Tiller mode (EFB settings / Sim options / Tiller setting enabled)
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.