feat(fms): fms-v2 aircraft specific config / VNAV parameters

fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_FlightPlanPage.js

@@ -1076,10 +1076,10 @@ function formatAltitudeOrLevel(mcdu, alt, useTransAlt) {
     let isFl = false;
     if (useTransAlt) {
         const transAlt = activePlan.performanceData.transitionAltitude;
-        isFl = transAlt !== undefined && alt > transAlt;
+        isFl = transAlt !== null && alt > transAlt;
     } else {
         const transLevel = activePlan.performanceData.transitionLevel;
-        isFl = transLevel !== undefined && alt >= (transLevel * 100);
+        isFl = transLevel !== null && alt >= (transLevel * 100);
     }
 
     if (isFl) {

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A320AircraftConfig.ts

@@ -0,0 +1,58 @@
+// Copyright (c) 2021-2024 FlyByWire Simulations
+//
+// SPDX-License-Identifier: GPL-3.0
+
+import {
+  AircraftConfig,
+  EngineModelParameters,
+  FlightModelParameters,
+  LnavConfig,
+  VnavConfig,
+  VnavDescentMode,
+} from '@fmgc/flightplanning/new/AircraftConfigTypes';
+
+const lnavConfig: LnavConfig = {
+  DEFAULT_MIN_PREDICTED_TAS: 160,
+  TURN_RADIUS_FACTOR: 1.0,
+  NUM_COMPUTED_TRANSITIONS_AFTER_ACTIVE: -1,
+};
+
+const vnavConfig: VnavConfig = {
+  VNAV_DESCENT_MODE: VnavDescentMode.NORMAL,
+  VNAV_EMIT_CDA_FLAP_PWP: false,
+  DEBUG_PROFILE: false,
+  DEBUG_GUIDANCE: false,
+  ALLOW_DEBUG_PARAMETER_INJECTION: false,
+  VNAV_USE_LATCHED_DESCENT_MODE: false,
+  IDLE_N1_MARGIN: 3,
+  MAXIMUM_FUEL_ESTIMATE: 40000,
+};
+
+const flightModelParams: FlightModelParameters = {
+  Cd0: 0.01873,
+  wingSpan: 117.454,
+  wingArea: 1317.47,
+  wingEffcyFactor: 0.7,
+  requiredAccelRateKNS: 1.33,
+  requiredAccelRateMS2: 0.684,
+  gravityConstKNS: 19.0626,
+  gravityConstMS2: 9.806665,
+  machValues: [0.55, 0.6, 0.65, 0.7, 0.75, 0.8, 0.85],
+  dragCoefficientCorrections: [0, 0.0002, 0.0003, 0.0004, 0.0008, 0.0015, 0.01],
+  speedBrakeDrag: 0.01008,
+  gearDrag: 0.0372,
+  dragCoeffFactor: 1,
+};
+
+const engineModelParams: EngineModelParameters = {
+  maxThrust: 27120,
+  numberOfEngines: 2,
+  fuelBurnFactor: 1.0,
+};
+
+export const A320AircraftConfig: AircraftConfig = {
+  lnavConfig,
+  vnavConfig,
+  engineModelParameters: engineModelParams,
+  flightModelParameters: flightModelParams,
+};

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A380AircraftConfig.ts

@@ -0,0 +1,57 @@
+// Copyright (c) 2023-2024 FlyByWire Simulations
+//
+// SPDX-License-Identifier: GPL-3.0
+
+import {
+  AircraftConfig,
+  EngineModelParameters,
+  FlightModelParameters,
+  LnavConfig,
+  VnavConfig,
+  VnavDescentMode,
+} from '@fmgc/flightplanning/new/AircraftConfigTypes';
+
+const lnavConfig: LnavConfig = {
+  DEFAULT_MIN_PREDICTED_TAS: 160,
+  TURN_RADIUS_FACTOR: 1.0,
+  NUM_COMPUTED_TRANSITIONS_AFTER_ACTIVE: -1,
+};
+
+const vnavConfig: VnavConfig = {
+  VNAV_DESCENT_MODE: VnavDescentMode.NORMAL,
+  VNAV_EMIT_CDA_FLAP_PWP: false,
+  DEBUG_PROFILE: false,
+  DEBUG_GUIDANCE: false,
+  ALLOW_DEBUG_PARAMETER_INJECTION: false,
+  VNAV_USE_LATCHED_DESCENT_MODE: false,
+  IDLE_N1_MARGIN: 2,
+  MAXIMUM_FUEL_ESTIMATE: 250_000,
+};
+
+const flightModelParams: FlightModelParameters = {
+  wingSpan: 262.467,
+  wingArea: 9096,
+  wingEffcyFactor: 0.7,
+  requiredAccelRateKNS: 1.33,
+  requiredAccelRateMS2: 0.684,
+  gravityConstKNS: 19.0626,
+  gravityConstMS2: 9.806665,
+  machValues: [0.55, 0.6, 0.65, 0.7, 0.75, 0.8, 0.85],
+  dragCoefficientCorrections: [0, 0.0002, 0.0003, 0.0004, 0.0008, 0.0015, 0.01],
+  speedBrakeDrag: 0.0201,
+  gearDrag: 0.00872,
+  dragCoeffFactor: 0.87,
+};
+
+const engineModelParams: EngineModelParameters = {
+  maxThrust: 80_213,
+  numberOfEngines: 4,
+  fuelBurnFactor: 2.73,
+};
+
+export const A380AircraftConfig: AircraftConfig = {
+  lnavConfig,
+  vnavConfig,
+  engineModelParameters: engineModelParams,
+  flightModelParameters: flightModelParams,
+};

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/AircraftConfigTypes.ts

@@ -0,0 +1,130 @@
+// Copyright (c) 2021-2022 FlyByWire Simulations
+//
+// SPDX-License-Identifier: GPL-3.0
+
+export enum VnavDescentMode {
+  NORMAL,
+  CDA,
+  DPO,
+}
+
+export interface AircraftConfig {
+  lnavConfig: LnavConfig;
+  vnavConfig: VnavConfig;
+  engineModelParameters: EngineModelParameters;
+  flightModelParameters: FlightModelParameters;
+}
+
+export interface VnavConfig {
+  /**
+   * VNAV descent calculation mode (NORMAL, CDA or DPO)
+   */
+  VNAV_DESCENT_MODE: VnavDescentMode;
+
+  /**
+   * Whether to emit CDA flap1/2 pseudo-waypoints (only if VNAV_DESCENT_MODE is CDA)
+   */
+  VNAV_EMIT_CDA_FLAP_PWP: boolean;
+
+  /**
+   * Whether to pring debug information and errors during the VNAV computation.
+   */
+  DEBUG_PROFILE: boolean;
+
+  /**
+   * Whether to print guidance debug information on the ND
+   */
+  DEBUG_GUIDANCE: boolean;
+
+  /**
+   * Whether to use debug simvars (VNAV_DEBUG_*) to determine aircraft position and state.
+   * This is useful for testing VNAV without having to fly the aircraft. This lets you put the aircraft some distance before destination at a given altitude and speed.
+   * The following simvars can be used:
+   * - A32NX_FM_VNAV_DEBUG_POINT: Indicates the distance from start (NM) at which to draw a debug pseudowaypoint on the ND
+   * - A32NX_FM_VNAV_DEBUG_ALTITUDE: Indicates the indicated altitude (ft) VNAV uses for predictions
+   * - A32NX_FM_VNAV_DEBUG_SPEED: Indicates the indicated airspeed (kts) VNAV uses for predictions
+   * - A32NX_FM_VNAV_DEBUG_DISTANCE_TO_END: Indicates the distance (NM) to end VNAV uses for predictions
+   */
+  ALLOW_DEBUG_PARAMETER_INJECTION: boolean;
+
+  VNAV_USE_LATCHED_DESCENT_MODE: boolean;
+
+  /**
+   * Percent N1 to add to the predicted idle N1. The real aircraft does also use a margin for this, but I don't know how much
+   */
+  IDLE_N1_MARGIN: number;
+
+  /**
+   * VNAV needs to make an initial estimate of the fuel on board at destination to compute the descent path.
+   * We don't want this figure to be too large as it might crash the predictions. So we clamp it to this value.
+   * This value is in lbs.
+   */
+  MAXIMUM_FUEL_ESTIMATE: number;
+}
+
+/** Only covers aircraft specific configs, no debug switches */
+export interface LnavConfig {
+  /* ========== PATHGEN CONFIG ========== */
+
+  /**
+   * The minimum TAS we ever compute guidables with
+   */
+  DEFAULT_MIN_PREDICTED_TAS: number;
+
+  /**
+   * Coefficient applied to all transition turn radii
+   */
+  TURN_RADIUS_FACTOR: number;
+
+  /**
+   * The number of transitions to compute after the active leg (-1: no limit, compute all transitions)
+   */
+  NUM_COMPUTED_TRANSITIONS_AFTER_ACTIVE: number;
+}
+
+export interface EngineModelParameters {
+  /** In pounds of force. Used as a multiplier for results of table 1506 */
+  maxThrust: number;
+
+  /** Well... how many engines the plen has */
+  numberOfEngines: number;
+
+  /** Fuel burn relative to A320 / base implementation */
+  fuelBurnFactor: number;
+}
+
+export interface FlightModelParameters {
+  Cd0?: number;
+
+  wingSpan: number;
+
+  wingArea: number;
+
+  wingEffcyFactor: number;
+
+  /** in knots/second */
+  requiredAccelRateKNS: number;
+
+  /** in m/s^2 */
+  requiredAccelRateMS2: number;
+
+  /** in knots/second */
+  gravityConstKNS: number;
+
+  /** in m/s^2 */
+  gravityConstMS2: number;
+
+  /** From https://github.com/flybywiresim/a32nx/pull/6903#issuecomment-1073168320 */
+  machValues: Mach[];
+
+  dragCoefficientCorrections: number[];
+
+  /** Drag coefficient increase due to extended speed brake */
+  speedBrakeDrag: number;
+
+  /** Drag coefficient increase due to extended speed brake */
+  gearDrag: number;
+
+  /** Drag coefficient factor for tuning */
+  dragCoeffFactor: number;
+}

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/DataManager.ts

@@ -52,7 +52,7 @@ type PbdWaypoint = {
   pbdDistance: NauticalMiles;
 };
 
-export type PilotWaypoint = LatLonWaypoint | PbxWaypoint | PbdWaypoint;
+export type PilotWaypoint = LatLonWaypoint | PbxWaypoint | PbdWaypoint | null;
 
 export class DataManager {
   private static readonly STORED_WP_KEY: string = 'A32NX.StoredWaypoints';

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/FlightPlanService.ts

@@ -407,7 +407,7 @@ export class FlightPlanService<P extends FlightPlanPerformanceData = FlightPlanP
   async addOrEditManualHold(
     at: number,
     desiredHold: HoldData,
-    modifiedHold: HoldData,
+    modifiedHold: HoldData | undefined,
     defaultHold: HoldData,
     planIndex = FlightPlanIndex.Active,
     alternate = false,

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/WaypointEntryUtils.ts

@@ -26,7 +26,7 @@ export class WaypointEntryUtils {
     fms: DataInterface & DisplayInterface,
     place: string,
     stored: boolean,
-    ident: string,
+    ident?: string,
   ): Promise<Fix | undefined> {
     if (WaypointEntryUtils.isLatLonFormat(place)) {
       const coordinates = WaypointEntryUtils.parseLatLon(place);

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/interface/DisplayInterface.ts

@@ -10,12 +10,12 @@ export interface DisplayInterface {
   /**
    * Called when a flight plan uplink is in progress
    */
-  onUplinkInProgress();
+  onUplinkInProgress(): void;
 
   /**
    * Called when a flight plan uplink is done
    */
-  onUplinkDone();
+  onUplinkDone(): void;
 
   /**
    * Calling this function with a message should display 1the message in the FMS' message area,
@@ -24,7 +24,7 @@ export interface DisplayInterface {
    *
    * @param errorType the message to show
    */
-  showFmsErrorMessage(errorType: FmsErrorType);
+  showFmsErrorMessage(errorType: FmsErrorType): void;
 
   /**
    * Calling this function with an array of items should display a UI allowing the user to