feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

flogross89 · 2024-02-15T01:43:35Z

Summary of Changes

Introduces A380 specific engine and flight model parameters to enable VNAV (predictions).
Includes changes to fms-v2 to enable TS strict mode compliance for the MFD
Adds units to JSDoc in FlightPlanPerformanceData
Change representation of not-set values from undefined to null (also improves behavior when using event bus sync)

Screenshots (if necessary)

n/a

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

For A320: Should behave exactly as before, no change expected. Pay attention to VNAV predictions and vertical guidance, e.g. during approach
For A380: Testing being done separately

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

fix(fms-v2): don't require explicit Fmgc namespace reference when calling fmgc's DataManager

…o fms-v2

…-v2-aircraft-config-2 # Conflicts: # fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts

…-v2-aircraft-config-2 # Conflicts: # fbw-a32nx/src/systems/fmgc/src/efis/EfisSymbols.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/FlightPlanService.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/WaypointEntryUtils.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/interface/DisplayInterface.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/BaseFlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/FlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/performance/FlightPlanPerformanceData.ts # fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts # fbw-a32nx/src/systems/fmgc/src/guidance/lnav/LnavDriver.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CostIndex.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CruiseToDescentCoordinator.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/EngineModel.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/FlightModel.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/Predictions.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/VerticalProfileManager.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/VnavDriver.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbStrategy.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/cruise/CruisePathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/ApproachPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentStrategy.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/GeometricPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/takeoff/TakeoffPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/index.ts # fbw-a32nx/src/systems/fmgc/src/navigation/Navigation.ts

flogross89 · 2024-04-28T23:29:32Z

lint-fixed

# Conflicts: # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_AvailableArrivalsPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_AvailableDeparturesPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_DirectToPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_FlightPlanPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_InitPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_LateralRevisionPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_PerformancePage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_ProgressPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_StepAltsPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_VerticalRevisionPage.js # fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js # fbw-a32nx/src/systems/fmgc/src/NavigationDatabase.ts # fbw-a32nx/src/systems/fmgc/src/efis/EfisInterface.ts # fbw-a32nx/src/systems/fmgc/src/efis/EfisSymbols.ts # fbw-a32nx/src/systems/fmgc/src/efis/EfisVectors.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/DataManager.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/FlightPlanInterface.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/FlightPlanService.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/WaypointEntryUtils.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/interface/DisplayInterface.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/legs/FlightPlanLeg.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/BaseFlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/FlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/performance/FlightPlanPerformanceData.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/rpc/FlightPlanRpcClient.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/segments/OriginSegment.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/uplink/CoRouteUplinkAdapter.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/new/uplink/SimBriefUplinkAdapter.ts # fbw-a32nx/src/systems/fmgc/src/guidance/Geometry.ts # fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts # fbw-a32nx/src/systems/fmgc/src/guidance/lnav/LnavDriver.ts # fbw-a32nx/src/systems/fmgc/src/guidance/lnav/legs/FA.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/VerticalProfileManager.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/VnavDriver.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/ApproachPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts # fbw-a32nx/src/systems/fmgc/src/index.ts # fbw-a32nx/src/systems/fmgc/src/navigation/NavaidSelectionManager.ts # fbw-a32nx/src/systems/fmgc/src/navigation/Navigation.ts # fbw-common/src/systems/navdata/client/backends/Msfs/Mapping.ts # fbw-common/src/systems/navdata/client/backends/Msfs/Msfs.ts

fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CostIndex.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/EngineModel.ts

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A380AircraftConfig.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentStrategy.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/takeoff/TakeoffPathBuilder.ts

fbw-a32nx/src/systems/fmgc/src/navigation/Navigation.ts

Benjozork

Thanks for the patch!

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A320AircraftConfig.ts

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A380AircraftConfig.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CostIndex.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/EngineModel.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbPathBuilder.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentStrategy.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts

fbw-a32nx/src/systems/fmgc/src/guidance/vnav/takeoff/TakeoffPathBuilder.ts

fbw-a32nx/src/systems/fmgc/src/index.ts

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/AircraftConfigInterface.ts

…acers comments)

…ile and var naming

flogross89 · 2024-06-15T15:11:40Z

@tracernz @Benjozork thanks for the review! Last commits should address all your remarks

BlueberryKing and others added 30 commits January 21, 2024 21:06

Fix duplicate disco after NEW DEST

cbc64f1

Fix missed approach being strung twice

453aa59

Merge remote-tracking branch 'upstream/master' into fms-v2

092f430

Fix TF DF leg conversion with XI legs

578930b

Deduplicate waypoints when inserting into flightplan

ba41654

Fix origin being active leg initially

76bc206

Add IF for procedures starting with FX

3352127

Implement FROM/TO leg deletion

07a4834

fix: fms-v2 fmgc variable ref (flybywiresim#8376)

e6609fe

fix(fms-v2): don't require explicit Fmgc namespace reference when calling fmgc's DataManager

Always compute IF at runway/airport

0ffc721

Merge branch 'fms-v2' of https://github.com/flybywiresim/aircraft int…

3cb41ca

…o fms-v2

Only restring to enroute if arrival changed

72b262c

Fix arrival not being rebuilt for transition change

7c61201

Reset enroute transition when arrival changes

7408d51

Show ILS frequency on Arrivals page

cafdd42

Set active leg when arrival changes while flying it

3d01124

Deduplicate after airway entry

ccb1ca9

Create disco but no tmpy on waypoint entry

e16e3d2

Fix missing approach vias with Navigraph data

d31c219

Remove MagVar class

4380fca

Fix no disco for waypoint insertion before destination

702cdc2

Fix being able to clear PPOS

61f5d09

fix: cleanup docker images for more space

548ad23

Remove deleted import

19722e6

Merge branch 'fms-v2' of https://github.com/flybywiresim/aircraft int…

5a76afd

…o fms-v2

Improve airway entry perf by filtering at db level

e9d385d

Fix typo in constraint parsing

20bb626

Port AIRPORT key functionality

42a95f9

Remove unnecessary navdata workaround

50e7eb4

Remove accidental CSS changes

2b14603

BlueberryKing and others added 5 commits April 28, 2024 13:13

Allow SID without runway

bdd35b8

Merge commit '8aee5c4d4b46dc2e46f1ff0098b0f2f07eafe17b' into feat-fms…

1708525

…-v2-aircraft-config-2 # Conflicts: # fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts

Merge branch 'fms-v2' into feat-fms-v2-aircraft-config-2

24a1872

lint-fix

1c92aa8

flogross89 added 3 commits May 1, 2024 00:58

fix lint error, don't include debug switches in a/c specific lnav config

897e322

fix build :/

a8ada8c

flogross89 changed the base branch from fms-v2 to master June 15, 2024 14:16

flogross89 added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft and removed Do Not Merge Not Ready For Testing Not ready for testing as still being discussed or developed. labels Jun 15, 2024

flogross89 moved this from ⌛ Awaiting Actions to 🟣 QA Team Review: Ready to Test in Quality Assurance Jun 15, 2024

tracernz requested changes Jun 15, 2024

View reviewed changes

Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to 🔴 Code Review: In progress Jun 15, 2024

Benjozork requested changes Jun 15, 2024

View reviewed changes

flogross89 added 3 commits June 15, 2024 17:54

make legEta non-static, update copyright claims, remove facLoader (tr…

05f512a

…acers comments)

holland's comments: update copyright claims, remove exports, change f…

1e64e5d

…ile and var naming

don't delete one more copyright claim

8c2119a

flogross89 requested review from Benjozork and tracernz June 15, 2024 15:10

fix merge error

c84ba2e

Benjozork approved these changes Jun 15, 2024

View reviewed changes

flogross89 added the QA Ready to Test label Jun 15, 2024

tracernz approved these changes Jun 15, 2024

View reviewed changes

Quality Assurance automation moved this from 🔴 Code Review: In progress to 🟣 QA Team Review: Ready to Test Jun 15, 2024

flogross89 mentioned this pull request Jun 17, 2024

feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2, with VNAV #8510

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

flogross89 commented Feb 15, 2024 •

edited

flogross89 commented Apr 28, 2024

Benjozork left a comment

flogross89 commented Jun 15, 2024

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

Are you sure you want to change the base?

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

Conversation

flogross89 commented Feb 15, 2024 • edited

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

flogross89 commented Apr 28, 2024

Benjozork left a comment

Choose a reason for hiding this comment

flogross89 commented Jun 15, 2024

flogross89 commented Feb 15, 2024 •

edited